Skip to content

improve ldc on windows#7409

Merged
waruqi merged 1 commit intodevfrom
dlang
Mar 19, 2026
Merged

improve ldc on windows#7409
waruqi merged 1 commit intodevfrom
dlang

Conversation

@waruqi
Copy link
Member

@waruqi waruqi commented Mar 19, 2026

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the xmake build system's compatibility with the LDC2 D language compiler on Windows. It resolves a specific issue where the linker flags for library directories were incorrectly formatted for the MSVC linker used by LDC2, ensuring that projects can now link successfully on the Windows platform.

Highlights

  • LDC2 Windows Linker Flags: Implemented a new function nf_linkdir to correctly format linker directory flags for LDC2 when building on Windows. This addresses the requirement of msvc link.exe for /libpath: instead of -libpath:.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@waruqi waruqi added this to the v3.0.8 milestone Mar 19, 2026
@gemini-code-assist
Copy link
Contributor

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

@waruqi waruqi closed this Mar 19, 2026
@waruqi waruqi reopened this Mar 19, 2026
@waruqi waruqi merged commit 14b831a into dev Mar 19, 2026
97 of 103 checks passed
@waruqi waruqi deleted the dlang branch March 19, 2026 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant