add manifest mode support for vcpkg package depend-info by kanren3 · Pull Request #7411 · xmake-io/xmake

kanren3 · 2026-03-19T12:26:02Z

#7388
The package dependency in manifest mode still has issues.

gemini-code-assist · 2026-03-19T12:26:20Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances Xmake's integration with Vcpkg by adding comprehensive support for Vcpkg's manifest mode. The changes enable Xmake to correctly interpret and manage package dependencies that utilize manifest files for versioning, feature selection, and baseline definitions, thereby resolving existing issues with package dependency resolution in this mode.

Highlights

Vcpkg Manifest Mode Detection: Introduced a new function _need_manifest to determine if Vcpkg's manifest mode should be activated based on package options like required version, features, default features, or baseline.
Feature Extraction Enhancement: Added a helper function _required_features to robustly extract required features from both the package name string (e.g., curl[openssl]) and the configuration options.
Manifest Mode Integration in Package Finding: Modified the core _find_package function to leverage the new manifest mode detection, enforce the installdir requirement for manifest mode, and adjust the lookup path for Vcpkg info directories accordingly.
Vcpkg Command Argument Updates: Updated the vcpkg depend-info and vcpkg list commands to include --feature-flags=versions and set the current directory (curdir) when operating in manifest mode, ensuring accurate dependency tree and installation status retrieval.
Utility Function Adaptations: Adjusted the is_installed and has_installed_features utility functions to accept and propagate manifest mode parameters, allowing them to correctly query Vcpkg in a manifest-aware context.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request adds support for vcpkg's manifest mode when querying package dependency information. The changes correctly detect when to use manifest mode, execute vcpkg commands in the project's installation directory, and pass necessary flags. The implementation is solid, but I have a couple of suggestions to improve maintainability by reducing code duplication and clarifying a comment.

gemini-code-assist · 2026-03-19T12:31:02Z

xmake/modules/package/manager/vcpkg/find_package.lua

+    -- pass feature flags to depend-info when in manifest mode, otherwise depend-info will not show the complete dependency tree with features
+    if manifest_mode then
+        table.insert(argv, 1, "--feature-flags=versions")
+    end
+
+    local _, dependinfo = try { function () return os.iorunv(vcpkg, argv, manifest_mode and {curdir = opt.installdir} or nil) end }


This logic for preparing and executing a vcpkg command with manifest mode support is duplicated in xmake/modules/package/manager/vcpkg/utils.lua inside the is_installed function. To improve maintainability and reduce code duplication, consider abstracting this into a helper function within the vcpkg_utils module. This would also be a good place to define "--feature-flags=versions" as a constant.

gemini-code-assist · 2026-03-19T12:31:02Z

xmake/modules/package/manager/vcpkg/utils.lua

+    -- pass feature flags to depend-info when in manifest mode, otherwise depend-info will not show the complete dependency tree with features
+    if manifest_mode then
+        table.insert(argv, 1, "--feature-flags=versions")
+    end


This comment is misleading as it refers to depend-info, but this function calls vcpkg list. Please update the comment to reflect the correct command and its purpose.

-- pass feature flags to the `list` command when in manifest mode to get correct information for packages with features if manifest_mode then table.insert(argv, 1, "--feature-flags=versions") end

waruqi · 2026-03-19T13:02:47Z

xmake/modules/package/manager/vcpkg/find_package.lua

 import("package.manager.pkgconfig.find_package", {alias = "find_package_from_pkgconfig"})

+-- need manifest mode?
+function _need_manifest(opt)


跟 install_package.lua 里重复了，移到 utils 里去复用下

waruqi · 2026-03-19T13:05:17Z

xmake/modules/package/manager/vcpkg/utils.lua

 --
-function is_installed(vcpkg, name, triplet)
+
+function is_installed(vcpkg, name, triplet, manifest_mode, opt)


参数太多了，有些放到 opt 里面去。

另外这个 install_package.lua 里也用了，同步了么？

waruqi · 2026-03-20T06:08:26Z

xmake/modules/package/manager/vcpkg/find_package.lua

 import("package.manager.pkgconfig.find_package", {alias = "find_package_from_pkgconfig"})

+-- extract required features from both package name and configs.features.
+local function _required_features(name, configs)


不用加 local

waruqi · 2026-03-20T06:08:50Z

另外，rebase 下，dev 修了 ci 的问题

Issues-translate-bot · 2026-03-20T06:29:55Z

Bot detected the issue body's language is not English, translate it automatically.

In addition, under rebase, dev fixed the ci problem.

kanren3 · 2026-03-20T06:55:44Z

另外，rebase 下，dev 修了 ci 的问题

OK了

Issues-translate-bot · 2026-03-20T06:55:54Z

Bot detected the issue body's language is not English, translate it automatically.

In addition, under rebase, dev fixed the ci problem

OK

gemini-code-assist bot reviewed Mar 19, 2026

View reviewed changes

waruqi reviewed Mar 19, 2026

View reviewed changes

waruqi added this to the v3.0.8 milestone Mar 19, 2026

waruqi closed this Mar 19, 2026

waruqi reopened this Mar 19, 2026

waruqi reviewed Mar 20, 2026

View reviewed changes

kanren3 added 3 commits March 20, 2026 14:41

add manifest mode support for vcpkg package depend-info

101c700

Move need_manifest to utils and fix install_package.lua.

c7be1fa

Make _required_features function public

9a66881

kanren3 force-pushed the dev branch from f74b2be to 9a66881 Compare March 20, 2026 06:43

waruqi merged commit 8b1b876 into xmake-io:dev Mar 20, 2026
37 checks passed

Uh oh!

Conversation

kanren3 commented Mar 19, 2026

Uh oh!

gemini-code-assist bot commented Mar 19, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

waruqi Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

kanren3 Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

waruqi Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

kanren3 Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

waruqi Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

waruqi commented Mar 20, 2026

Uh oh!

Issues-translate-bot commented Mar 20, 2026

Uh oh!

kanren3 commented Mar 20, 2026

Uh oh!

Issues-translate-bot commented Mar 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants