Memory and stability fixes to XLForm #1045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unable to display when value than apples first selectorOptions
# Conflicts: # XLForm/XL/Cell/XLFormSelectorCell.m
mats-claassen
requested changes
Feb 12, 2019
mats-claassen
approved these changes
Feb 18, 2019
Memory fixes & code refactor by Vitaly
mats-claassen
requested changes
Mar 14, 2019
| rowDescriptorCopy.isDirtyHidePredicateCache = YES; | ||
| rowDescriptorCopy.validators = [self.validators mutableCopy]; | ||
|
|
||
Member
There was a problem hiding this comment.
Again. remove trailing whitespaces. This goes against style guidelines
Member
|
1 month of tests - there are no crashes on memory warnings |
mats-claassen
approved these changes
Mar 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following fixes helped our app to be a lot more stable in production with thousands of users using the app heavily.
library before the fixes had many memory issues.
please review the fixes - they should be a great benefit to you.