Skip to content

moveToViewController does not change the page if created + not visible + animated = false until it become visible #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

moveToViewController does not change the page if created + not visible + animated = false until it become visible #746

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5a1a067
Skip visiblility check (view.window != nil) if non animated viewContr…
bivant Aug 13, 2019
a71a69d
Merge branch 'master' into MoveToController_nonanimatedWhenNotVisible
bivant Aug 13, 2019
c428dcc
Fix non animated selected viewController show (was always first one) …
bivant Aug 26, 2019
dfcd7d3
Code style: tabs -> spaces
bivant Aug 26, 2019
434ba29
#2, addition to c428dcc180125e0e4db975c1b45278d3d9358504 : Fix non an…
bivant Aug 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Sources/PagerTabStripViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ open class PagerTabStripViewController: UIViewController, UIScrollViewDelegate {
}

open func moveToViewController(at index: Int, animated: Bool = true) {
guard isViewLoaded && view.window != nil && currentIndex != index else {
guard isViewLoaded && (view.window != nil || animated == false) && currentIndex != index else {
preCurrentIndex = index
return
}
Expand All @@ -166,6 +166,10 @@ open class PagerTabStripViewController: UIViewController, UIScrollViewDelegate {
(navigationController?.view ?? view).isUserInteractionEnabled = !animated
containerView.setContentOffset(CGPoint(x: pageOffsetForChild(at: index), y: 0), animated: true)
} else {
if(view.window == nil) {
preCurrentIndex = index
currentIndex = index //in case of bounds change - otherwise the contentOffset is being reset in updateContent()
}
(navigationController?.view ?? view).isUserInteractionEnabled = !animated
containerView.setContentOffset(CGPoint(x: pageOffsetForChild(at: index), y: 0), animated: animated)
}
Expand Down