Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #465 +/- ##
=======================================
Coverage 21.45% 21.45%
=======================================
Files 7 7
Lines 713 713
=======================================
Hits 153 153
Misses 558 558
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| ) | ||
|
|
||
| func TestRequirePartnerIDs(t *testing.T) { | ||
| type badType int |
There was a problem hiding this comment.
this eventually gets passed to cast.ToStringSliceE since spf13/cast was updated it can cast ints into strings so this no longer is malformed so changed it to an array of empty structs.
| f = pflag.NewFlagSet(applicationName, pflag.ContinueOnError) | ||
| v = viper.New() | ||
|
|
||
| logger, metricsRegistry, webPA, err = server.Initialize(applicationName, arguments, f, v, webhook.Metrics, aws.Metrics, basculehelper.AuthCapabilitiesMetrics, basculehelper.AuthValidationMetrics, consul.Metrics, Metrics, service.Metrics) |
There was a problem hiding this comment.
per my convo with @denopink - consul.Metrics is not needed - service.Metrics is what is the actual metrics for consul.
|
Looks good! Keep up the good work 🍻 |
3 participants
No description provided.