Skip to content

feat: enhance remote claim builder: introduce Path Value options#339

Merged
denopink merged 5 commits intomainfrom
denopink/feat/remote-builder-path-values
Mar 24, 2026
Merged

feat: enhance remote claim builder: introduce Path Value options#339
denopink merged 5 commits intomainfrom
denopink/feat/remote-builder-path-values

Conversation

@denopink
Copy link
Copy Markdown
Contributor

@denopink denopink commented Mar 24, 2026

  • enables the use of rest/crud remote claim builders that rely on url path values
  • update tests
  • update config example

@denopink denopink requested a review from johnabass March 24, 2026 16:23
@denopink denopink self-assigned this Mar 24, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2026

Codecov Report

❌ Patch coverage is 83.33333% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.35%. Comparing base (c787c1a) to head (44582d4).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
token/transport.go 77.50% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #339      +/-   ##
==========================================
+ Coverage   50.74%   51.35%   +0.61%     
==========================================
  Files          55       55              
  Lines        2020     2064      +44     
==========================================
+ Hits         1025     1060      +35     
- Misses        963      969       +6     
- Partials       32       35       +3     
Flag Coverage Δ
unittests 51.35% <83.33%> (+0.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- enables the use of remote claim builders that rely on url path values
- update tests
- update config example
@denopink denopink force-pushed the denopink/feat/remote-builder-path-values branch from 0803a74 to 5f7c435 Compare March 24, 2026 17:10
@denopink denopink added the enhancement New feature or request label Mar 24, 2026
- introduce the ability to pass in the entire themis `Request` struct, allowing for easier integration of future remote claim builder related features
- update tests
- allows for greater response encoding flexibility
Copy link
Copy Markdown
Contributor

@johnabass johnabass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a good idea. we should probably create a full swagger for themis

@denopink
Copy link
Copy Markdown
Contributor Author

denopink commented Mar 24, 2026

this is a good idea. we should probably create a full swagger for themis

John means the internal remote claims server we're implementing and not themis

@denopink denopink merged commit 67d949a into main Mar 24, 2026
18 checks passed
@denopink denopink deleted the denopink/feat/remote-builder-path-values branch March 24, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants