refactor: remote claim builder: simplify AddClaims#346
Merged
Conversation
Contributor
denopink
commented
Mar 25, 2026
denopink
commented
- use maps.Copy over range
- use maps.Copy over range
denopink
changed the base branch from
main
to
denopink/refactor/improve-pathvalues-name-
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #346 +/- ##
==========================================
- Coverage 51.35% 51.09% -0.27%
==========================================
Files 55 55
Lines 2064 2053 -11
==========================================
- Hits 1060 1049 -11
Misses 969 969
Partials 35 35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
johnabass
approved these changes
Mar 26, 2026
Contributor
johnabass
left a comment
johnabass
left a comment
There was a problem hiding this comment.
good job switching to use the new maps package!
Base automatically changed from
denopink/refactor/improve-pathvalues-name-
to
main
March 26, 2026 19:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.