Skip to content

Comments

X.P.Eval reexport defaultEvalConfig#37

Merged
geekosaur merged 1 commit intoxmonad:masterfrom
geekosaur:reexport-eval-config
Feb 17, 2026
Merged

X.P.Eval reexport defaultEvalConfig#37
geekosaur merged 1 commit intoxmonad:masterfrom
geekosaur:reexport-eval-config

Conversation

@geekosaur
Copy link
Contributor

It's in X.A.Eval, but the documentation doesn't tell you that you need to import it from there. And really, you shouldn't have to; it should be reexported.

(Yes, I know we've gone all def, but I still consider it a very bad idea especially after it caused breakage with the hide/show docks key.)

@geekosaur
Copy link
Contributor Author

This can't be merged until CI is fixed (#36 which is still WIP).

@geekosaur geekosaur force-pushed the reexport-eval-config branch from b2b3fa1 to 0ddd6ad Compare February 14, 2026 16:15
@geekosaur
Copy link
Contributor Author

Gaaah. Something up with Ubuntu repos or GHA's ability to access them?

@geekosaur geekosaur force-pushed the reexport-eval-config branch from 0ddd6ad to 1635b4d Compare February 16, 2026 21:32
@geekosaur
Copy link
Contributor Author

So, while the commit to fix CI passed as a PR, somehow after commit it became necessary to add a sudo apt update before installing the necessary Ubuntu packages. I'm not sure if this is a mirror issue, an Ubuntu issue, or a GitHub issue. I've slipstreamed it into this PR.

@liskin
Copy link
Member

liskin commented Feb 16, 2026

So, while the commit to fix CI passed as a PR, somehow after commit it became necessary to add a sudo apt update before installing the necessary Ubuntu packages. I'm not sure if this is a mirror issue, an Ubuntu issue, or a GitHub issue. I've slipstreamed it into this PR.

Probably just a timing issue. Whatever Ubuntu image it's running, it has apt lists from a few days/weeks ago so it might work for a bit and then stop. The workflows in xmonad have had apt update for aaaages

It's in `X.A.Eval`, but the documentation doesn't tell you that you need
to import it from there. And really, you shouldn't have to; it should be
reexported.

(Yes, I know we've gone all `def`, but I still consider it a very bad
idea especially after it caused breakage with the hide/show docks key.)
@geekosaur geekosaur force-pushed the reexport-eval-config branch from 1635b4d to a767d09 Compare February 17, 2026 02:25
@geekosaur
Copy link
Contributor Author

FTR I ended up slipping it into the other PR, which has an approval and therefore got merged first. Rebasing caused it to disappear here.

@geekosaur geekosaur merged commit 162f61e into xmonad:master Feb 17, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants