Allow dev/gen-proto to supply a different proto path#75
Merged
Conversation
Falls back to the default `buf.build/xmtp/proto` when no argument is provided, preserving existing behavior. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
neekolas
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #73
Summary
dev/gen-protonow accepts an optional positional argument for the proto pathbuf.build/xmtp/protowhen no argument is providedUsage
Test plan
./dev/gen-protowith no arguments — should behave identically to before./dev/gen-proto <custom-path>— should use the provided path instead🤖 Generated with Claude Code
Note
Allow
dev/gen-prototo accept a custom proto source path argumentAdds a
PROTO_PATHvariable to dev/gen-proto that reads the first positional argument, defaulting tobuf.build/xmtp/proto. Thebuf generatecall now uses this variable instead of the hardcoded path, so a different proto source can be passed at the command line without modifying the script.Macroscope summarized 70a12fd.