Add HTTP server timeouts to mitigate slowloris/slow-read DoS#1895
Open
xmtp-coder-agent wants to merge 1 commit intoxmtp:mainfrom
Open
Add HTTP server timeouts to mitigate slowloris/slow-read DoS#1895xmtp-coder-agent wants to merge 1 commit intoxmtp:mainfrom
xmtp-coder-agent wants to merge 1 commit intoxmtp:mainfrom
Conversation
Mitigates slowloris and slow-read DoS attacks by configuring missing timeouts on the http.Server: ReadHeaderTimeout (10s), ReadTimeout (30s), and WriteTimeout (5m). Removes the TODO comment about needing more timeouts. Resolves xmtp#1888 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1888
Summary
ReadHeaderTimeout(10s),ReadTimeout(30s), andWriteTimeout(5m) to the APIhttp.Serverto mitigate slowloris and slow-read denial-of-service attacksTimeout Rationale
ReadHeaderTimeoutReadTimeoutWriteTimeoutIdleTimeout— must be long enough for server-streaming RPCs likeSubscribeEnvelopesTest Plan
go build ./pkg/api/...compiles cleanlygo vet ./pkg/api/...passes🤖 Generated with Claude Code
Note
Add HTTP server timeouts to mitigate slowloris/slow-read DoS attacks
Sets
ReadHeaderTimeout(10s),ReadTimeout(30s), andWriteTimeout(5m) on thehttp.Serverinapi.NewAPIServer. These timeouts protect against slowloris and slow-read denial-of-service attacks by bounding how long the server waits on a client. Behavioral Change: all API requests are now subject to these timeouts, where previously none were enforced.Macroscope summarized a54a5fc.