Open
Conversation
This commit fixes the following compile error with `-Wreturn-type`.
```
In file included from ./ruby_xnd_internal.h:52:
./util.h:148:6: error: non-void function 'rb_range_unpack' should return a value [-Wreturn-type]
return;
^
float_pack_unpack.c:76:17: warning: comparison of integers of different signs: 'int' and 'unsigned long' [-Wsign-compare]
for (i = 0; i < sizeof(float); ++i) {
~ ^ ~~~~~~~~~~~~~
float_pack_unpack.c:105:23: warning: comparison of integers of different signs: 'int' and 'unsigned long' [-Wsign-compare]
for (i = 0; i < sizeof(float); ++i) {
~ ^ ~~~~~~~~~~~~~
float_pack_unpack.c:143:17: warning: comparison of integers of different signs: 'int' and 'unsigned long' [-Wsign-compare]
for (i = 0; i < sizeof(double); ++i) {
~ ^ ~~~~~~~~~~~~~~
float_pack_unpack.c:166:23: warning: comparison of integers of different signs: 'int' and 'unsigned long' [-Wsign-compare]
for (i = 0; i < sizeof(double); ++i) {
~ ^ ~~~~~~~~~~~~~~
7 warnings and 1 error generated.
```
Fix compile error
A library must not add any methods to core classes. It remarkably reduces both the reliability and the availability of this library.
Remove needless files
Remove needless monkey patching for String
Author
|
@mrkn merged. |
Member
|
This is the strange load error: |
Member
|
Perhaps an |
Author
|
@skrah can you please try |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruby wrapper for XND.