fix: COMMENT ON
syntax
#301
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @xnuinside,
thank you for this parser!
In my tests, I couldn't get the "COMMENT ON" syntax to parse successfully. So, I tried to fix it by myself.
It seems to work now. I added correspondent tests. All tests have passed and pre-commit was executed.
This also solves #173 and potentially also #269 and #297
Please have look if you have time and let me know what you think.
Test:
Original error:
With this PR, the columns (and tables) get their "comment" attribute filled correctly through corresponding "COMMENT ON" statements.