Fix #872 by reserve null title string.

[Akarinnnnn]

#872 reported an inconsistency between nullable annotation and possible value. In case of no title exists in a link syntax, consumers except Title property returns a null string. But current behavior is Title returning an empty string, This PR fixes the inconsistency by make Title property null if link title is not exist.

[Akarinnnnn]

Sounds good, I misunderstood the meaning of callsite.

…

---Original--- From: "Miha ***@***.***&gt; Date: Sat, May 31, 2025 23:23 PM To: ***@***.***&gt;; Cc: ***@***.******@***.***&gt;; Subject: Re: [xoofx/markdig] Fix #872 by reserve null title string. (PR #876) @MihaZupan commented on this pull request. In src/Markdig/Helpers/HtmlHelper.cs: &gt; @@ -465,6 +465,24 @@ private static bool TryParseHtmlTagProcessingInstruction(ref StringSlice text, r } } + /// <summary&gt; + /// Destructively unescape a string: remove backslashes before punctuation or symbol characters. + /// </summary&gt; + /// <param name="text"&gt;The string data that will be changed by unescaping any punctuation or symbol characters.</param&gt; + /// <param name="removeBackSlash"&gt;if set to <c&gt;true</c&gt; [remove back slash].</param&gt; + /// <returns&gt;Unescaped text, or null if <paramref name="text"/&gt; is null.<returns&gt; + public static string? UnescapeNullable(string? text, bool removeBackSlash = true) I'm not suggesting to change the behavior of Unescape, but to change the one call site -Title = HtmlHelper.UnescapeNullable(title, removeBackSlash: false), +Title = title is null ? null : HtmlHelper.Unescape(title, removeBackSlash: false), — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ***@***.***&gt;