Skip to content

add options for link inline#894

Merged
xoofx merged 3 commits intoxoofx:masterfrom
danielklecha:master
Oct 3, 2025
Merged

add options for link inline#894
xoofx merged 3 commits intoxoofx:masterfrom
danielklecha:master

Conversation

@danielklecha
Copy link
Contributor

Hi,

I want to fix issue #886.

I added options class but it's only used if user replace default parser.
Feel free to comment and give me clues :)

AutoLinkOptions has few more properties but I didn't implement it.

Does anything else should be changed?

@danielklecha
Copy link
Contributor Author

danielklecha commented Oct 3, 2025

@MihaZupan could you recheck my changes?

  1. I added comment with license information
  2. I created LinkOptions.cs and associated it with all four parsers
  3. I moved EnableHtmlParsing into options class in AutolinkInlineParser - we break backward compatibility in this place but I think that we should keep options in one place.
  4. I think that I added _target attribute correctly but please check it because I could have missed something.

@danielklecha
Copy link
Contributor Author

I fixed tests.

@xoofx xoofx merged commit 4dc0be8 into xoofx:master Oct 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants