Recognize supplementary characters#913
Conversation
|
I ran Unit Test in my VS 2026 with .NET 6/8/9 locally and all test cases succeeded. |
|
Thanks for the work! LGTM. Quite heavy with the Rune polyfill but we don't have much choices. @MihaZupan anything other feedback? |
|
Rune is based on the latest snapshot of https://source.dot.net/#System.Private.CoreLib/src/libraries/System.Private.CoreLib/src/System/Text/Rune.cs,a0cdde85f676b935. |
|
If we adopt C# 14, we can use Extension Members instead of creating the |
Could you get by with making the existing |
I moved the new members to the existing |
I don't think it's needed |
|
I see. Let me know if we should move it from |
|
@MihaZupan I have finished correcting all sections where your additional responses were not required. |
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
|
I managed to get all tests passed again. |
| // Advance to the next character, checking for a valid surrogate pair | ||
| char.IsHighSurrogate(Text[start++]) | ||
| // Don't unconditionally increment `start` here. Check the surrogate code unit at `start` is a part of a valid surrogate pair first. | ||
| && start <= End |
There was a problem hiding this comment.
Is this covered by https://github.com/xoofx/markdig/pull/913/changes#diff-e66da161369de25c14420f6b83bc176a4b7240b03cee5f9478e67335faa6d0a7R243? (the above if (start >= End))
|
I will need to merge |
|
I hope the new workflow works. |
|
@MihaZupan I did all what I have to do now. Please let me know if I still have ones. The ball is in your court now. You can directly push commits here if necessary. |
|
I opened a PR against your fork with some cleanup tats-u#1 |
|
@MihaZupan Couldn't you directly push to my branch? |
|
Sure, but for the most part I try not to do that to avoid breaking contributors' workflows by messing up their branch. Pressing merge on the PR in your repo has the same effect. |
PR feedback
From now on, please feel free to add commits as needed, then just press “Squash and merge” at the end (all messy commits will be aggregated into a single commit). |
|
Thank you for your approval. |
Thank for your work! I will do a release later tonight. |

Fixes #860