ENH: cosyvoice support pt file #2431
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
docker设置参考： |
|
Is this PR ready for review? |
yes 😄 |
|
Can you add some doc to to tell users how to leverage this feature? |
committed |
|
Please fix the GPU CI: https://github.com/xorbitsai/inference/actions/runs/11323214004/job/31485465795?pr=2431. It would be good to add a CI case for the .pt file as well. |
codingl2k1
reviewed
Oct 15, 2024
| newspk = self.pt_cache[spk_id] | ||
| for i in self.frontend.text_normalize(tts_text, split=True): | ||
| model_input = self.frontend.frontend_sft(i, spk_id) | ||
| if newspk is not None: |
There was a problem hiding this comment.
Is it possible that the newspk is not defined? e.g. the if condition above is not true.
| return spks | ||
|
|
||
| def inference_sft(self, tts_text, spk_id, stream=False): | ||
| if spk_id not in self.default_voices and os.environ["COSYVOICE_PT_PATH"] is not None: |
There was a problem hiding this comment.
The os.environ["COSYVOICE_PT_PATH"] may raise a KeyError when spk_id not in self.default_voices. Is this expected?
|
Any update? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you need to use a custom .pt file, please set the folder path of the .pt file in the environment variable
COSYVOICE_PT_PATHbeforehand.如果需要使用自定义pt文件，请先在环境变量
COSYVOICE_PT_PATH中设置pt文件所在的文件夹路径