feat: implement zhipu and alibaba coding plan providers#138
Merged
qinxuye merged 1 commit intoxorbitsai:mainfrom Mar 12, 2026
Merged
feat: implement zhipu and alibaba coding plan providers#138qinxuye merged 1 commit intoxorbitsai:mainfrom
qinxuye merged 1 commit intoxorbitsai:mainfrom
Conversation
qinxuye
reviewed
Mar 12, 2026
bsbds
force-pushed
the
feat/more-providers
branch
2 times, most recently
from
1c9f0b4 to
ccc33e8
Compare
qinxuye
reviewed
Mar 12, 2026
bsbds
force-pushed
the
feat/more-providers
branch
from
ccc33e8 to
3ff861a
Compare
tanbro
added a commit
to tanbro/xagent
that referenced
this pull request
Mar 13, 2026
PR xorbitsai#138 (cee1e49) introduced a provider compatibility system that incorrectly overrode user-configured base URLs with default values. The problematic code used: base_url=model.base_url or default_base_url_for_provider(...) This fails when base_url is an empty string ("") because Python's `or` operator treats empty strings as falsy, causing the fallback to activate even when the user explicitly configured a base URL. For OpenAI-compatible providers like DashScope that store base_url="" in the database, this caused requests to be sent to api.openai.com instead of their configured endpoints. As a result, task execution failed to start completely - tasks showed blank responses with no backend execution activity. This fix reverts to direct provider string comparison and removes the fallback logic, trusting the database configuration as-is. Fixes task execution regression introduced in cee1e49 (PR xorbitsai#138) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
qinxuye
pushed a commit
that referenced
this pull request
Mar 13, 2026
…ion (#141) * fix: revert incorrect base_url fallback logic that breaks task execution PR #138 (cee1e49) introduced a provider compatibility system that incorrectly overrode user-configured base URLs with default values. The problematic code used: base_url=model.base_url or default_base_url_for_provider(...) This fails when base_url is an empty string ("") because Python's `or` operator treats empty strings as falsy, causing the fallback to activate even when the user explicitly configured a base URL. For OpenAI-compatible providers like DashScope that store base_url="" in the database, this caused requests to be sent to api.openai.com instead of their configured endpoints. As a result, task execution failed to start completely - tasks showed blank responses with no backend execution activity. This fix reverts to direct provider string comparison and removes the fallback logic, trusting the database configuration as-is. Fixes task execution regression introduced in cee1e49 (PR #138) * fix: add coding plan providers --------- Co-authored-by: tanbro <tanbro@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.