Skip to content

feat: make serve outbound display schema in and schema out#1454

Open
tibisabau wants to merge 2 commits intoxorq-labs:mainfrom
tibisabau:1211-serve-outbound-display-schemas
Open

feat: make serve outbound display schema in and schema out#1454
tibisabau wants to merge 2 commits intoxorq-labs:mainfrom
tibisabau:1211-serve-outbound-display-schemas

Conversation

@tibisabau
Copy link

@tibisabau tibisabau commented Dec 9, 2025

Summary

This PR enhances the xorq serve-unbound command to display the input and output schema of the expression being served. Closes #1211.

The code is generated by Claude Sonnet 4.5.

Changes

  • Add exchanger instantiation
  • Log schema-in
  • Log schema-out
  • Preserve existing server behavior

Copilot AI review requested due to automatic review settings December 9, 2025 16:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the xorq serve-unbound command to display the input and output schemas of the expression being served before starting the server. This helps users understand what data structure the server expects and produces.

  • Add logging of schema-in (required input schema) and schema-out (output schema) information
  • Instantiate UnboundExprExchanger to access schema metadata
  • Preserve existing server behavior and functionality

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
python/xorq/cli.py 0.00% 4 Missing ⚠️
Files with missing lines Coverage Δ
python/xorq/cli.py 71.21% <0.00%> (-1.10%) ⬇️

... and 231 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 10, 2025

CodSpeed Performance Report

Merging #1454 will not alter performance

Comparing tibisabau:1211-serve-outbound-display-schemas (0a09afa) with main (a6f3e47)

Summary

✅ 4 untouched

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: serve-unbound should display schema-in and schema out of the expr being served

2 participants