fix: add decompile() handlers for custom xorq relation types#1705
Open
paddymul wants to merge 1 commit intoxorq-labs:mainfrom
Open
fix: add decompile() handlers for custom xorq relation types#1705paddymul wants to merge 1 commit intoxorq-labs:mainfrom
paddymul wants to merge 1 commit intoxorq-labs:mainfrom
Conversation
Regression tests for xorq-labs#1702. decompile() has no handlers for CachedNode, RemoteTable, FlightUDXF, or Read — they all fall back to the generic DatabaseTable handler which discards parent/remote_expr/input_expr/ read_kwargs fields. 8 tests: 4 check dispatch registration, 4 check decompiled output. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
... and 192 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Merging this PR will degrade performance by 33.89%
Performance Changes
Comparing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
decompile()has no@translate.register()handlers forCachedNode,RemoteTable,FlightUDXF, orReadDatabaseTablehandler, which emits a plainibis.table(name=..., schema=...)and silently discardsparent,remote_expr,input_expr,read_kwargs, etc.Test plan
python/xorq/vendor/ibis/expr/test_decompile.pyCloses #1702
🤖 Generated with Claude Code