Skip to content

Conversation

thekid
Copy link
Member

@thekid thekid commented Jul 18, 2023

This pull request migrates the code to use xp-framework/reflection. As this changes the API, we will releases this as a major release, 5.0.0 at the time of writing.

Performance

No measurable impact.

Before

$ xp test src/test/php
# ...
Test cases:  156 succeeded
Memory used: 3847.27 kB (3901.40 kB peak)
Time taken:  0.078 seconds (0.159 seconds overall)

After

$ xp test src/test/php
# ...
Test cases:  156 succeeded
Memory used: 3639.90 kB (3694.02 kB peak)
Time taken:  0.079 seconds (0.157 seconds overall)

See also

@thekid thekid merged commit 0988a3e into master Jul 22, 2023
@thekid thekid deleted the refactor/reflection branch July 22, 2023 08:38
thekid added a commit to xp-forge/handlebars-templates that referenced this pull request Jul 22, 2023
@thekid
Copy link
Member Author

thekid commented Jul 22, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant