-
Notifications
You must be signed in to change notification settings - Fork 4
Changes on google search client #18
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API doc is wrong here, since the constructor only accepts an URL string now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the hint :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some APIdocs here - and think about including a link to the documentation (e.g. https://developers.google.com/search-appliance/documentation/52/QuickStart/quick_start_se#dynamicresclust - maybe use the newest version, but you get the picture), as I'm not sure everyone knows what search "clusters" are. The term "cluster" usually refers to a load-balanced group of 2..n machines configured in the same way and serving the same purpose, not "group[ing] search results by topic".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well , partly true - cluster is in textmining/datamining clustering has a different meaning. But you're definitly right, that there have to be a link to the google documentation
|
lets merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems the toString() function is using a wrong indentation (maybe tabs instead of spaces).
|
+0.9, see comment and suggestion on testability above. |
Customized the gsa search client for retrieving clustered search results