Typo3 9 #4
Typo3 9 #4
Conversation
DavidBruchmann
commented
Jun 7, 2019
DavidBruchmann
commented
- Use currently newest version of pelago/emogrifer for usage with also php-7.3.
- Remove packaging as phar due to problems with phar-files outside extensions.
- Update despite depreciation due to seemingly additional optional settings in comparison to extension emogrifier.
- Backwards compatibility with TYPO3 7 and 8 is not tested.
…o php-7.3. remove packaging as phar due to problems with phar-files outside extensions. Update despite depreciation due to seemingly additional optional settings in comparison to extension emogrifier.
| "typo3/cms": ">= 7.6.0, <= 8.7.99", | ||
| "pelago/emogrifier": "^1.2" | ||
| "php": ">= 5.5.0, <= 7.3.99", | ||
| "typo3/cms-core": ">= 7.6.0, <= 9.5.99", |
There was a problem hiding this comment.
TYPO3 v7 is not maintained anymore (except ELTS but I don't care).
Point is the dependency to typo3/cms-core is wrong for TYPO3 v7 since it does not exist there. Please see the tags on https://packagist.org/packages/typo3/cms-core
Next, having the dependency to v8 and v9 only means PHP dependency should be changed to at least 7.0
There was a problem hiding this comment.
You're right, I forgot about the missing versions of cms-core.
| "html", | ||
| "newsletters" | ||
| ], | ||
| "version": "7.0.0", |
There was a problem hiding this comment.
version should not be hardcoded, it is inferred from git tag.
There was a problem hiding this comment.
Ok, I never understood that till this easy explanation ;-)
pi1/class.tx_css2inline_pi1.php
Outdated
| if (is_file($pharFileName)) { | ||
| @include 'phar://' . $pharFileName . '/vendor/autoload.php'; | ||
| } | ||
| */ |
There was a problem hiding this comment.
with that change, the extension can unfortunately not be installed through TER and this is uncool even if I'm the first one to only use composer nowadays :(
There was a problem hiding this comment.
That's right. And I'm well aware that you spent some time for that code and that in composer.json.
There was a problem hiding this comment.
is it possible to make a branch for a composer-only-version "typo3_9_composer" or somehow named like that?
Like that at least it's available for composer.
I don't know if it's very problematic to solve the problem with the phar-files outside the extension-directory, but storing it in the extension-directory is probably not so clean as solution.
| 'category' => 'plugin', | ||
| 'shy' => 0, | ||
| 'version' => '0.3.0-dev', | ||
| 'version' => '7.0.0', |
There was a problem hiding this comment.
What??? How can you justify to bump the version from 0.x to 7.0 ??? 1.0.0 (-dev) would be OK but I absolutely don't see how you could jump to an arbitrary 7.0.0.
There was a problem hiding this comment.
Was related to TYPO3 Version 7, but if you want to bump that, I'd even would propose 8.0.0.
That scheme is used by other extensions like gridelements too.
There was a problem hiding this comment.
On the other hand we've no separated version for TYPO3 8 and 9, so I'm fine with a version-scheme that is independent from TYPO3 version.
|
Any reason why you want to still use this extension and not switch to EXT:emogrifier as suggested in the |
|
Yeah, main reason is that the extension was used already in a project and everything was adjusted for it.
|
2 participants
