Skip to content

Conversation

@cev-api
Copy link
Contributor

@cev-api cev-api commented Dec 17, 2025

Activate with /sm:minimap and configure with /sm:config seedmapminimap*

Enjoy!

…imap

# Conflicts:
#	src/main/java/dev/xpple/seedmapper/seedmap/SeedMapScreen.java
@vanvac
Copy link

vanvac commented Dec 21, 2025

the minimap implementation locked the zoom in/out on the seed map with the minimap on, but this was on cev-api's build with all the other stuff idk if it applies to this as well.
also um ...

[17:51:57] [Render thread/ERROR]: Reported exception thrown!
net.minecraft.class_148: Rendering screen
	at knot//net.minecraft.class_757.method_3192(class_757.java:545)
	at knot//net.minecraft.class_310.method_1523(class_310.java:1393)
	at knot//net.minecraft.class_310.method_1514(class_310.java:966)
	at knot//net.minecraft.client.main.Main.main(Main.java:250)
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:514)
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:72)
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
	at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:105)
	at org.prismlauncher.EntryPoint.listen(EntryPoint.java:129)
	at org.prismlauncher.EntryPoint.main(EntryPoint.java:70)
Caused by: java.lang.ArithmeticException: / by zero
	at java.base/java.lang.Math.ceilDiv(Math.java:1690)
	at knot//dev.xpple.seedmapper.seedmap.SeedMapScreen.renderBiomes(SeedMapScreen.java:354)
	at knot//dev.xpple.seedmapper.seedmap.SeedMapScreen.method_25394(SeedMapScreen.java:337)
	at knot//net.minecraft.class_437.method_47413(class_437.java:119)
	at knot//net.minecraft.class_757.mixinextras$bridge$method_47413$111(class_757.java)
	at knot//net.minecraft.class_757.wrapOperation$boi000$fabric-screen-api-v1$onRenderScreen(class_757.java:2486)
	at knot//net.minecraft.class_757.method_3192(class_757.java:537)
	... 9 more
``` we are dividing by zero somewhere (latest action build from this pr)

@xpple
Copy link
Owner

xpple commented Dec 21, 2025

The zoom locking I solved. Is this crash log from the most recent commit?

Edit: It is. I think this is caused by your PixelsPerBiome config being set to zero, can you verify this (/sm:config PixelsPerBiome get)?

@vanvac
Copy link

vanvac commented Dec 22, 2025

oh yea that might be the problem, i had the zoom set to like 0.022... from cev-apis fork, thats probably why

@cev-api
Copy link
Contributor Author

cev-api commented Dec 22, 2025

Yeah I made some changes to the minimap after that pr branch. Sorry for the hassle. I need to improve my QC 😅

All reported issues are solved on my master branch. Such as zoom not working when minimap open and biomes not changing in minimap.

@xpple
Copy link
Owner

xpple commented Dec 22, 2025

Thanks!

@xpple xpple merged commit fb3a3bd into xpple:master Dec 22, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants