Conversation
keefertaylor
left a comment
keefertaylor
left a comment
There was a problem hiding this comment.
Can you also just update the root README.md in a sane way. Our tech writing team will eventually re-write so don't worry too much about it.
python/main.py
Outdated
|
|
||
| import xpring | ||
|
|
||
|
|
There was a problem hiding this comment.
super nit: extra blank line
There was a problem hiding this comment.
This line is part of the Google style, but I'll remove it.
keefertaylor
left a comment
keefertaylor
left a comment
There was a problem hiding this comment.
Oh actually, is it a pain to prove this builds via CI? You should just be able to add a new step to .circleci/config.yml
I think you'll need to install poetry here since I don't see in the default packages.
|
Thanks for doing this. Excited to get this out there! + devx-reviewers to get a second set of eyes. |
keefertaylor
requested review from
a team and
0xCLARITY
and removed request for
a team
0xCLARITY
left a comment
0xCLARITY
left a comment
There was a problem hiding this comment.
Nice! How does this work exactly? Does Python have a way to call JS code?
.circleci/config.yml
Outdated
|
|
||
| - run: | ||
| name: "Run Python SDK Demo" | ||
| command: cd java && poetry install && poetry run python main.py |
| @@ -0,0 +1,34 @@ | |||
| import time | |||
|
|
|||
| import xpring | |||
There was a problem hiding this comment.
Where does xpring come from?
There was a problem hiding this comment.
I publish this package to PyPI: https://pypi.org/project/xpring/
There was a problem hiding this comment.
It is a Python implementation of serialization, signing, and gRPC for XRPL. No calls to JavaScript.
0xCLARITY
left a comment
0xCLARITY
left a comment
There was a problem hiding this comment.
LGTM! Awesome that you implemented this!
|
Apologies that CI was misconfigured. If you tickle this build it should give you an actual result now. |
|
How do we get libgmp installed on the MacOS image used by CircleCI? |
|
Apologies this has sat in my review queue for so long. I think you can just add |
|
CI on this will fail until #37 is merged. I'd love to see this merged afterwards. |
4 participants
You can see a GitHub rendering of the directory here.