This repository was archived by the owner on Jan 19, 2024. It is now read-only.
Open
Conversation
added 9 commits
August 24, 2020 14:16
amiecorso
approved these changes
Aug 25, 2020
Contributor
amiecorso
left a comment
amiecorso
left a comment
There was a problem hiding this comment.
This is looking good Ryan. I just fixed some cosmetic stuff - I know this is probably just stuff you retained from the original demos, but I figure now is a good time to clean it up a little.
| public static void main(String[] args) throws PayIdException { | ||
| // The Pay ID to resolve. | ||
| String payId = "alice$dev.payid.xpring.money"; | ||
|
|
| // The BTC network to resolve on. | ||
| String btcNetwork = "btc-testnet"; | ||
|
|
||
| // A client to resolve PayIDs on any network.. |
Contributor
There was a problem hiding this comment.
Suggested change
| // A client to resolve PayIDs on any network.. | |
| // A client to resolve PayIDs on any network. |
|
|
||
| // The XRP Ledger network to resolve on. | ||
| XrplNetwork xrpNetwork = XrplNetwork.MAIN; | ||
|
|
| // The PayID to resolve. | ||
| const payId = "alice$dev.payid.xpring.money"; | ||
|
|
||
| // A client to resolve PayIDs on the Bitcoin testnet. |
Contributor
There was a problem hiding this comment.
Suggested change
| // A client to resolve PayIDs on the Bitcoin testnet. | |
| // A client to resolve PayIDs on any network. |
| // A client to resolve PayIDs on the XRP Ledger. | ||
| const xrpPayIdClient = new XrpPayIdClient(xrpNetwork); | ||
|
|
||
| // A client to resolve PayIDs on the Bitcoin testnet. |
Contributor
There was a problem hiding this comment.
Suggested change
| // A client to resolve PayIDs on the Bitcoin testnet. | |
| // A client to resolve PayIDs on any network. |
| import Foundation | ||
| import XpringKit | ||
|
|
||
| // The Pay ID to resolve. |
Contributor
There was a problem hiding this comment.
Suggested change
| // The Pay ID to resolve. | |
| // The PayID to resolve. |
| // The Pay ID to resolve. | ||
| let payID = "alice$dev.payid.xpring.money" | ||
|
|
||
| // A client to resolve PayIDs on any network.. |
Contributor
There was a problem hiding this comment.
Suggested change
| // A client to resolve PayIDs on any network.. | |
| // A client to resolve PayIDs on any network. |
| // A client to resolve PayIDs on any network.. | ||
| let payIDClient = PayIDClient() | ||
|
|
||
| // Resolve all addresses |
Contributor
There was a problem hiding this comment.
Suggested change
| // Resolve all addresses | |
| // Resolve all addresses. |
| // Resolve on Bitcoin testnet. | ||
| let btcNetwork = "btc-testnet" | ||
|
|
||
| // A client to resolve PayIDs on any network.. |
Contributor
There was a problem hiding this comment.
Suggested change
| // A client to resolve PayIDs on any network.. | |
| // A client to resolve PayIDs on any network. |
| import Foundation | ||
| import XpringKit | ||
|
|
||
| // The Pay ID to resolve. |
Contributor
There was a problem hiding this comment.
Suggested change
| // The Pay ID to resolve. | |
| // The PayID to resolve. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Context of Change
This change was a simple refactor. It was necessary because if a user going through this demo did not not have a PayID associated with both the XRPL and BTC networks the demo would result in a fatal error. This refactor allows users to demo the PayID resolve according to the networks for which their PayID is associated.
Type of Change
Before / After
Before the refactor there was one file for each of the PayID demos according to their respective language NodeJS, Java, and Swift. After there is three files for each PayID demo according to their respective languages.
Test Plan
Using VS Code I was able to test the NodeJS refactored demos and Java (Maven) refactored demos which both resulted in expected output. I've been unable to test the refactored Swift demos thus they will need more attention.
@amiecorso can you review this?