fix: round-trip */N notation for large step intervals#88
Merged
xrutayisire merged 1 commit intomasterfrom Apr 3, 2026
Merged
Conversation
The `getStep` function requires 3+ values to detect step intervals, but large steps like `*/6` on months produce only 2 values (`[1, 7]`). This caused `partToString` to output `1,7` instead of `*/6`. Add a targeted check in `partToString` for 2-element arrays that form a full interval (starting from unit min, covering the full range). This restores `*/N` notation without changing output for non-full intervals or consecutive pairs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
partToStringto correctly output*/Nnotation when a 2-element array forms a full interval (e.g., months[1, 7]→*/6instead of1,7)getStepfunction requires 3+ values, so large steps like*/6on months (which produce only 2 values) were silently downgraded to comma notationCloses #69
Test plan
*/6months,*/30minutes,*/12hours — all verify round-trip and dropdown display*/Nfixes, 0 collateral changes🤖 Generated with Claude Code