Add NormalizedParticles class for coordinate transformations#630
Open
carlidel wants to merge 1 commit intoxsuite:mainfrom
Open
Add NormalizedParticles class for coordinate transformations#630carlidel wants to merge 1 commit intoxsuite:mainfrom
carlidel wants to merge 1 commit intoxsuite:mainfrom
Conversation
- Introduced NormalizedParticles class to handle transformations between physical and normalized coordinates efficiently. - Implemented norm_to_phys and phys_to_norm methods for converting particle data. - Updated TwissTable to include methods for obtaining normalized coordinates based on the new HybridClass. - Modified get_normalized_coordinates method to support both direct and context-based evaluations. - Added tests for NormalizedParticles in xtracl/tests/test_twiss.py
Author
|
Sorry for the delay... I tried to adapt the class from Xnlbd in order to make it more compliant to the Twiss notation in Xtrack. Let me know if any improvements are needed! Thanks for the support! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
NormalizedParticles enables the conversion to and from Twiss normalized coordinates directly on a xobjects context. This HybridClass can then be used for specific applications where a user may want to perform multiple coordinate conversions without breaking GPU parallelism (e.g. chaos indicators evaluations via ghost particle tracking, where re-normalization on normalized coordinates is required).
Future developments may consider the extension of this object as a beam element, in order to avoid the need to break a tracking action.
Checklist
Mandatory:
Optional: