Fix overload of abs for char type (part 2)

serge-sans-paille · serge-sans-paille · commit be9dcb5df413 · 2024-04-20T09:35:04.000Z
diff --git a/include/xsimd/arch/xsimd_scalar.hpp b/include/xsimd/arch/xsimd_scalar.hpp
@@ -93,11 +93,15 @@ namespace xsimd
 
     namespace detail
     {
-        inline char abs(char v, std::true_type)
+        // Use templated type here to prevent automatic instantiation that may
+        // ends up in a warning
+        template <typename char_type>
+        inline char abs(char_type v, std::true_type)
         {
             return v;
         }
-        inline char abs(char v, std::false_type)
+        template <typename char_type>
+        inline char abs(char_type v, std::false_type)
         {
             return v < 0 ? -v : v;
         }

Original file line number	Diff line number	Diff line change
`@@ -93,11 +93,15 @@ namespace xsimd`
`93`	`93`
`94`	`94`	`namespace detail`
`95`	`95`	`{`
`96`		`- inline char abs(char v, std::true_type)`
	`96`	`+ // Use templated type here to prevent automatic instantiation that may`
	`97`	`+ // ends up in a warning`
	`98`	`+ template <typename char_type>`
	`99`	`+ inline char abs(char_type v, std::true_type)`
`97`	`100`	`{`
`98`	`101`	`return v;`
`99`	`102`	`}`
`100`		`- inline char abs(char v, std::false_type)`
	`103`	`+ template <typename char_type>`
	`104`	`+ inline char abs(char_type v, std::false_type)`
`101`	`105`	`{`
`102`	`106`	`return v < 0 ? -v : v;`
`103`	`107`	`}`