Added first() function for SSE/AVX/AVX512F#1134
Merged
serge-sans-paille merged 4 commits intoxtensor-stack:masterfrom Jul 3, 2025
Merged
Added first() function for SSE/AVX/AVX512F#1134serge-sans-paille merged 4 commits intoxtensor-stack:masterfrom
serge-sans-paille merged 4 commits intoxtensor-stack:masterfrom
Conversation
…ted only for x86_64 architecture
Contributor
|
Looks good, but there is some formatting and windows - specific issue to handle, can you have a look? |
added 2 commits
July 2, 2025 21:21
Contributor
Author
|
These last 2 commits should be able to fix the previous issues |
Contributor
Author
|
oh nice it passed all the tests. Now we need to implement it for other architectures and replace all .get(0) with first() |
Contributor
I'll handle that. thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr implements new first() function for batch types. It is an improvement from the currently used self.get(0) as first() uses intrinsics to extract the first element. Addresses inefficiencies mentioned in issue #1133.
I have only implemented for SSE/AVX/AVX512F architectures @serge-sans-paille will implement for other architectures.
I also haven't replace any .get(0) functions with first(). That needs to be done as well