Skip to content

Fix: lstsq compilation with complex<float> inputs #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 15, 2025
Merged

Fix: lstsq compilation with complex<float> inputs #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d7feb5b
Add failing test for complex float input in lstsq
deniz-unal Jun 17, 2025
750a599
Fix complex float inputs for lstsq
deniz-unal Jun 17, 2025
c32382d
Merge branch 'master' into fix/complex_float_lstsq
JohanMabille Jul 15, 2025
cbf14ad
Migrated last test to doctest
JohanMabille Jul 15, 2025
d6555b4
linter
JohanMabille Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions include/xflens/cxxlapack/netlib/interface/dummy.in.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1026,21 +1026,21 @@ LAPACK_DECL(cgels)(const char *TRANS,

//-- cgelsd --------------------------------------------------------------------
void
LAPACK_DECL(cgelsd)(const INTEGER *M,
const INTEGER *N,
const INTEGER *NRHS,
FLOAT_COMPLEX *A,
const INTEGER *LDA,
FLOAT_COMPLEX *B,
const INTEGER *LDB,
FLOAT *S,
const FLOAT *RCOND,
INTEGER *RANK,
FLOAT_COMPLEX *WORK,
const INTEGER *LWORK,
FLOAT *RWORK,
INTEGER *IWORK,
INTEGER *INFO)
LAPACK_DECL(cgelsd)(const INTEGER *M,
const INTEGER *N,
const INTEGER *NRHS,
const FLOAT_COMPLEX *A,
const INTEGER *LDA,
FLOAT_COMPLEX *B,
const INTEGER *LDB,
FLOAT *S,
const FLOAT *RCOND,
INTEGER *RANK,
FLOAT_COMPLEX *WORK,
const INTEGER *LWORK,
FLOAT *RWORK,
INTEGER *IWORK,
INTEGER *INFO)
{
DEBUG_LAPACK_STUB("cgelsd");
LAPACK_IMPL(cgelsd)(M,
Expand Down
30 changes: 15 additions & 15 deletions include/xflens/cxxlapack/netlib/interface/lapack.in.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,21 +579,21 @@ LAPACK_IMPL(cgels)(const char *TRANS,

//-- cgelsd --------------------------------------------------------------------
void
LAPACK_IMPL(cgelsd)(const INTEGER *M,
const INTEGER *N,
const INTEGER *NRHS,
FLOAT_COMPLEX *A,
const INTEGER *LDA,
FLOAT_COMPLEX *B,
const INTEGER *LDB,
FLOAT *S,
const FLOAT *RCOND,
INTEGER *RANK,
FLOAT_COMPLEX *WORK,
const INTEGER *LWORK,
FLOAT *RWORK,
INTEGER *IWORK,
INTEGER *INFO);
LAPACK_IMPL(cgelsd)(const INTEGER *M,
const INTEGER *N,
const INTEGER *NRHS,
const FLOAT_COMPLEX *A,
const INTEGER *LDA,
FLOAT_COMPLEX *B,
const INTEGER *LDB,
FLOAT *S,
const FLOAT *RCOND,
INTEGER *RANK,
FLOAT_COMPLEX *WORK,
const INTEGER *LWORK,
FLOAT *RWORK,
INTEGER *IWORK,
INTEGER *INFO);

//-- cgelss --------------------------------------------------------------------
void
Expand Down
19 changes: 19 additions & 0 deletions test/test_linalg.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,6 +491,25 @@ namespace xt
CHECK(allclose(cel_1, std::get<1>(cres)));
CHECK_EQ(cel_2, std::get<2>(cres));
CHECK(allclose(cel_3, std::get<3>(cres)));

xarray<std::complex<float>> cfarg_0 = {{0.f, 1.f}, {1.f - 3if, 1.f}, {2.f, 1.f}, {3.f, 1.f}};
xarray<std::complex<float>> cfarg_1 = {{-1.f, 0.2f + 4if, 0.9f, 2.1f - 1if}, {2.f, 3if, 2.f, 1.f}};
cfarg_1 = transpose(cfarg_1);
auto cfres = xt::linalg::lstsq(cfarg_0, cfarg_1);

xarray<std::complex<float>, layout_type::column_major> cfel_0 = {
{-0.40425532f - 0.38723404if, -0.61702128f - 0.44680851if},
{1.44680851f + 1.02765957if, 2.51063830f + 0.95744681if}
};
xarray<float> cfel_1 = {16.11787234f, 2.68085106f};
int cfel_2 = 2;
xarray<float> cfel_3 = {5.01295356f, 1.36758789f};

CHECK(allclose(imag(cfel_0), imag(std::get<0>(cfres))));
CHECK(allclose(real(cfel_0), real(std::get<0>(cfres))));
CHECK(allclose(cfel_1, std::get<1>(cfres)));
CHECK_EQ(cfel_2, std::get<2>(cfres));
CHECK(allclose(cfel_3, std::get<3>(cfres)));
}

TEST_CASE("trace")
Expand Down