Skip to content

feat: Use cpp20 by default #2839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 9, 2025
Merged

feat: Use cpp20 by default #2839

merged 9 commits into from
Apr 9, 2025

Conversation

@sbstndb
Copy link
Contributor

@sbstndb sbstndb commented Apr 4, 2025 •
edited
Loading

Checklist

  • The title and commit message(s) are descriptive.
  • Small commits made to fix your PR have been squashed to avoid history pollution.
  • Tests have been added for new features or bug fixes.
  • API of new functions and classes are documented.

Description

Previously, xtensor uses c++17 as default.
Here is a PR that set c++20 by default.
This PR also suggests modifying the compilation option CPP20 to CPP23.

sbstndb and others added 9 commits April 3, 2025 10:45
@sbstndb
Update CMakeLists.txt
d8d75e7
@sbstndb
feat: Add c++23 option
46889a4 
	-	Previously, we had the option of activating c++20.
	-	But as we defined c++20 as default, I suggest to replace
			this option as c++23.
@sbstndb
feat: Use c++20 in tests
7365d80 
	-	Previously, tests was in c++17
	-	We want to add c++20 by default, so I modify the test cmake
	-	The tests passed locally
@sbstndb
fix: type
2f2e5a8
@sbstndb
fix: Add MSVC flag
7a0d20e 
	-	Previously, The MSVC version was not well recognized
		--> Hence, there was some bugy macro specific to MSVC/c++20
	-	This Commit resolve the issue and I am now able to
			compile the problematic testcase
	-	Question : SHould we add this flag not at the tets level
			but at the main CMakeFiles level ?
@sbstndb
fix: enforce specialization
93be135 
	-	Previously, on MSVC, in c++20, the empty() function was incorrectly deduced
	-	Hence the test_xbuilder no longer pass
	-	I suggest enforce the right specialization by specifying the last template parameter
@sbstndb
fix: resolve precommit issue
0d58759
@sbstndb
fix: Workaround to fix MSVC test
d615424
@sbstndb
doc: add comment
311a4b2
@JohanMabille JohanMabille changed the title feat: [WIP] Use cpp20 by default feat: Use cpp20 by default Apr 9, 2025
@gouarin gouarin mentioned this pull request Apr 9, 2025
Merged
@JohanMabille JohanMabille merged commit 7910a2d into xtensor-stack:master Apr 9, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohanMabille JohanMabille JohanMabille approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sbstndb @JohanMabille