Skip to content

Fix teleport when exiting out of alt buffer. v2 #5411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix teleport when exiting out of alt buffer. v2 #5411

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32c3cb0
Make sure this._latestYDisp is up to date
anthonykim1 Oct 1, 2025
2a6e22e
set this._latestYDisp = undefined onBufferActivate
anthonykim1 Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/browser/Viewport.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,12 @@ export class Viewport extends Disposable {
}));

this._register(this._bufferService.onResize(() => this.queueSync()));
this._register(this._bufferService.buffers.onBufferActivate(() => this.queueSync()));
this._register(this._bufferService.buffers.onBufferActivate(() => {
// Reset _latestYDisp when switching buffers to prevent stale scroll position
// from alt buffer contaminating normal buffer scroll position
this._latestYDisp = undefined;
this.queueSync();
}));
this._register(this._bufferService.onScroll(() => this._sync()));

this._register(this._scrollableElement.onScroll(e => this._handleScroll(e)));
Expand Down Expand Up @@ -157,7 +162,7 @@ export class Viewport extends Disposable {
});
this._suppressOnScrollHandler = false;

// If ydisp has been changed by some other copmonent (input/buffer), then stop animating smooth
// If ydisp has been changed by some other component (input/buffer), then stop animating smooth
// scroll and scroll there immediately.
if (ydisp !== this._latestYDisp) {
this._scrollableElement.setScrollPosition({
Expand Down
Loading