Fix IME composition overflow at right edge #5616
Open
+87
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent composition-view from extending beyond terminal boundary when cursor is at the right-most column. Add CSS overflow: hidden guardrail and enhance updateCompositionElements() to detect and correct overflow by repositioning the composition view left and down one line. Includes unit tests for overflow detection and position correction. Fixes xtermjs#5454
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the cursor is at the right-most column and IME composition text is long, the composition-view element can extend beyond the terminal boundary, causing the container to stretch horizontally.
This fix adds two layers of protection:
CSS: Add overflow: hidden to .xterm and .xterm .xterm-screen to prevent container stretching by internal elements.
Core logic: Enhance CompositionHelper.updateCompositionElements() to detect when the composition view would overflow the terminal width. When overflow is detected, the composition view is moved left and down one line to keep it within bounds, while maintaining IME candidate window alignment.
The fix includes unit tests to verify the overflow detection and position correction behavior.
Fixes #5454
Related to microsoft/vscode#282621