-
Notifications
You must be signed in to change notification settings - Fork 194
refactor: load firebase_admin lazily #279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@xtrinch I just pushed |
@xtrinch Sorry, I missed one error. I just fixed that one as well. |
@xtrinch I'm not sure how to fix the 3.7 action. onnx/tensorflow-onnx#2376 suggests limits 3.7 to ubuntu 22.04, maybe that's the solution? Let me know if there's anything I can do to help. |
Python 3.7 has reached its end of life, I believe we can safely remove it. |
According to In isolation, that probably doesn't sound like a lot, but I work on a project with a lot of different dependencies, so I'm always looking for ways to improve the import/setup speed of those dependencies. We tend to accumulate a lot of performance benefit by optimizing many of our different imports, so every little bit counts to the overall goal of improving django start time. For example, if we can improve the import time of 5 different dependencies that each take about 100ms to import and Thanks for your time and consideration. |
@jonesnc This latest release 2.3.1 bump up the ceiling for |
It looks like my project will take some work to update to |
Changes
Lazily import
firebase_admin
and its modules because we've found it's one of the slower modules to import in our Django projects. For type annotations, thefirebase_admin
is only imported after checkingtyping.TYPE_CHECKING
.Please let me know if you have any suggestions or feedback on this, I'd be happy to implement them.
Thanks for this package, I think it's great!
Tests