Bug fix for iCloud IMAP not returning valid data#32
Open
HuwSy wants to merge 11 commits intoxtsimpouris:mainfrom
Open
Bug fix for iCloud IMAP not returning valid data#32HuwSy wants to merge 11 commits intoxtsimpouris:mainfrom
HuwSy wants to merge 11 commits intoxtsimpouris:mainfrom
Conversation
xtsimpouris
reviewed
Nov 30, 2024
Owner
xtsimpouris
left a comment
xtsimpouris
left a comment
There was a problem hiding this comment.
There was no time to test, so added some comments to discuss before proceeding with merge. Thanks
| mailFolders[i] = { | ||
| "id": i, | ||
| "title": i, | ||
| "parent": "", |
Owner
There was a problem hiding this comment.
All folders in such a case are 1-level only?
Author
There was a problem hiding this comment.
Yes, this would only cope with single level mbox folders as I havent any further depth to test against and iCloud doesnt support nested folders for me to test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug in iCloud’s IMAP returning an int not str when requesting the email, so instead request binary and parse