Skip to content

build(docker): add @syncflow/bilibili to Docker and turbo pipeline#293

Merged
xun082 merged 1 commit intomainfrom
build/add-bilibili-docker-turbo
Feb 10, 2026
Merged

build(docker): add @syncflow/bilibili to Docker and turbo pipeline#293
xun082 merged 1 commit intomainfrom
build/add-bilibili-docker-turbo

Conversation

@xun082
Copy link
Copy Markdown
Owner

@xun082 xun082 commented Feb 10, 2026

PR 描述

PR 类型

  • 🐛 Bug 修复
  • ✨ 新功能
  • 💄 UI/UX 改进
  • ♻️ 重构
  • 🚀 性能优化
  • 📝 文档更新
  • 🔄 其他

Issue 关联

Closes #

其他信息

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 10, 2026

Deploy Preview for ornate-blancmange-89db6b failed. Why did it fail? →

Name Link
🔨 Latest commit a977c04
🔍 Latest deploy log https://app.netlify.com/projects/ornate-blancmange-89db6b/deploys/698ab93490438d000885a72e

@xun082 xun082 merged commit bdfa843 into main Feb 10, 2026
0 of 6 checks passed
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @xun082, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates the new @syncflow/bilibili package into the project's build infrastructure. It updates the Dockerfile to properly include the package's dependencies, source code, and built assets within the DocFlow application's Docker image. Additionally, the Turborepo configuration is extended to manage the build outputs for this new package, streamlining its inclusion in the monorepo's build pipeline.

Highlights

  • Dockerfile Updates: The Dockerfile has been modified to incorporate the @syncflow/bilibili package, ensuring its package.json, source code, and build artifacts are correctly copied and installed across different build stages.
  • Turborepo Configuration: The turbo.json file was updated to include a build configuration for @syncflow/bilibili, specifying its dist/** directory as build outputs.
Changelog
  • Dockerfile
    • Added packages/bilibili/package.json to the dependency installation stage.
    • Included packages/bilibili/ source directory in the build stage.
    • Updated comments to explicitly mention @syncflow/bilibili as a DocFlow frontend dependency.
    • Copied packages/bilibili/package.json for production dependencies.
    • Copied built dist and src/bilibili.css from @syncflow/bilibili to the final image.
  • turbo.json
    • Added a build task definition for @syncflow/bilibili with dist/** as its output.
Activity
  • No specific activity (comments, reviews, progress updates) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

本次 PR 主要将 @syncflow/bilibili 包集成到 Docker 构建流程和 Turborepo 流水线中。相关更改是正确的,能够确保新包被正确地安装、构建并包含在最终的生产镜像中。我提出了一些关于 Dockerfile 的建议,旨在通过减少重复的 COPY 指令来提高文件的可维护性。总体而言,这是一次不错的更新。

COPY .npmrc package.json pnpm-lock.yaml pnpm-workspace.yaml ./
COPY apps/DocFlow/package.json ./apps/DocFlow/package.json
COPY packages/alert/package.json ./packages/alert/package.json
COPY packages/bilibili/package.json ./packages/bilibili/package.json
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

这行 COPY 指令是重复代码块的一部分,该代码块也出现在 prod-deps 阶段。为了提高可维护性并避免重复,可以考虑创建一个专门用于收集所有 package.json 文件的中间阶段。这样,当未来添加或删除包时,您只需要在一个地方更新文件列表,从而减少出错的可能性。

例如,您可以添加一个新的 package-jsons 阶段,然后在 depsprod-deps 阶段中从该阶段复制文件。

Comment on lines +97 to +98
COPY --from=builder --chown=nextjs:nodejs /app/packages/bilibili/dist ./packages/bilibili/dist
COPY --from=builder --chown=nextjs:nodejs /app/packages/bilibili/src/bilibili.css ./packages/bilibili/src/bilibili.css
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

这些 COPY 指令为 @syncflow/bilibili 包添加了构建产物,但这种为每个包手动添加多行 COPY 指令的模式是重复的,并且随着包的增多会变得难以维护。可以考虑优化这一部分,例如,在 builder 阶段将所有需要的产物统一收集到一个公共目录中,然后在 runner 阶段只用一条 COPY 指令来复制整个目录。这样可以简化 Dockerfile 并减少未来出错的可能。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant