Fix X2022: Preserve all arguments when fixing negated boolean assertions #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #3446 - Code fixer was incorrectly removing second argument (userMessage) when converting Assert.True(!false) to Assert.False(false) - Modified BooleanAssertsShouldNotBeNegatedFixer to preserve all arguments - Added comprehensive tests for userMessage, multiple arguments, and named arguments - Existing simple case continues to work as before
Contributor
Author
|
@dotnet-policy-service agree |
Member
|
Thanks for the PR! The new tests are not passing in the automated PR build (failing in all three OSes, so it doesn't seem to be OS-specific). |
Tenno641
force-pushed
the
fix-x2022-preserve-user-message
branch
from
29917be to
5bc8d31
Compare
Contributor
Author
|
Hey @bradwilson |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes xunit/xunit#3446 - Code fixer was incorrectly removing second argument (userMessage) when converting Assert.True(!false) to Assert.False(false)