Fix/navigated within document null safety#415
Open
doonfrs wants to merge 2 commits intoxvrh:masterfrom
Open
Conversation
Add null safety handling for url and navigationType fields in NavigatedWithinDocumentEvent.fromJson to prevent runtime errors when these fields are null in the JSON response. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Use 'other' instead of empty string as fallback for navigationType to prevent "No element" error when the enum value is null. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NavigatedWithinDocumentEvent.fromJsonthat was causing runtime errorsurlandnavigationTypefields when they're null in the JSON responseProblem
On some browsers (possibly an old Chrome version), the application was throwing an error:
Type 'Null' is not a subtype of type 'String' in type castwhen receiving navigation events with null values for the url or navigationType fields.Solution
Added null-safe casting (
as String?) with fallback to empty string (?? '') for both fields to handle null values gracefully.Test plan
Error Stack Trace: