Create functional tests #45 #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* I added the pom.xmls
* I added the pom.xmls
*I added the classes need to interact with the configs from Analytics.Code.COnfiguration and I also added a class that will normalise the jsons from matomo
* I added the scripting service and the MatomoAnalyticsManager
*I added the livetable and everything seems to work okay for the time being.
* I modified the implementations of the JsonNormaliser to be a component and I also added the url + the document reference to the returned json.
* I restructured the packages and replaced the URLBuilder with a proper one.
* I added some comments. The final version of the pr.
* I added an if in the case that I switch back to the getPageTitles API
* I modified the dependencies and removed some parameters.
* I modified how I get the normaliser
* I added 2 tests and modified a few typos.
* I added some functions.
* Renamed the MostViewed hint to MostViewedPages and modified the comments
* Renamed 2 pages and added a test class for MatomoAnalyticsManager
*Changed the name of a file
* I added a test for the MatomoANalyticsManager
* I added new error messages and I updated the comments ona few functions.
* I added the JSON normalizer to transform the Matomo result into a format that can be easily processed in JavaScript for the Chart.js library. I also added two new Velocity macros and the JS code for displaying the evolution.
* I added a test for the RowEvolutionJsonNormaliser and added comments to the javascript code.
* Removed unused variables
* Removed unused livetable fields
* Dosen't work for the time being I can't connect to the matomo application from the testing container.
* Test for the description button
* BACKUP
* Added a few functional tests for the basic operations of the extension.
* Removed a file
mflorea
requested changes
Dec 8, 2023
Contributor
mflorea
left a comment
mflorea
left a comment
There was a problem hiding this comment.
Your code needs significant refactoring. I recommend checking the page objects and tests from XWiki platform to take inspiration from.
application-analytics-test/application-analytics-test-docker/pom.xml
Outdated
Show resolved
Hide resolved
application-analytics-test/application-analytics-test-docker/pom.xml
Outdated
Show resolved
Hide resolved
...ics-test-pageobjects/src/main/java/com/xwiki/analytics/test/po/MostViewedMacroViewPages.java
Outdated
Show resolved
Hide resolved
|
|
||
| public class Config | ||
| { | ||
| public static final String DB_CONTAINER_NAME = "farcasut/custom-mysql:latest"; |
Contributor
There was a problem hiding this comment.
The test needs to run on CI. I doubt this custom Docker container is published somewhere, but even if it is, we should use an official container.
Contributor
Author
There was a problem hiding this comment.
The container is currently publicly hosted on Docker Hub, but do you think it would be a better choice to create the container from scratch? Like using the default container and populating the database using the API provided by TestContainers
Contributor
There was a problem hiding this comment.
Long term we should move the container to an xwikisas account on Docker Hub.
...est/application-analytics-test-docker/src/test/it/xwiki/analytics/test/ui/config/Config.java
Outdated
Show resolved
Hide resolved
...est/application-analytics-test-docker/src/test/it/xwiki/analytics/test/ui/config/Config.java
Outdated
Show resolved
Hide resolved
...tion-analytics-test-pageobjects/src/main/java/com/xwiki/analytics/test/po/AdminViewPage.java
Outdated
Show resolved
Hide resolved
* -Update the poms.xml -Moved from a class with static methods to a normal one
* - More comments
oanalavinia
requested changes
Jan 9, 2024
...-test/application-analytics-test-docker/src/test/it/xwiki/analytics/test/ui/AnalyticsIT.java
Outdated
Show resolved
Hide resolved
...-test/application-analytics-test-docker/src/test/it/xwiki/analytics/test/ui/AnalyticsIT.java
Outdated
Show resolved
Hide resolved
...-test/application-analytics-test-docker/src/test/it/xwiki/analytics/test/ui/AnalyticsIT.java
Outdated
Show resolved
Hide resolved
...-test/application-analytics-test-docker/src/test/it/xwiki/analytics/test/ui/AnalyticsIT.java
Outdated
Show resolved
Hide resolved
...-test/application-analytics-test-docker/src/test/it/xwiki/analytics/test/ui/AnalyticsIT.java
Outdated
Show resolved
Hide resolved
...n-analytics-test-pageobjects/src/main/java/com/xwiki/analytics/test/po/HomePageEditPage.java
Outdated
Show resolved
Hide resolved
...test-pageobjects/src/main/java/com/xwiki/analytics/test/po/MostViewedPagesMacroViewPage.java
Outdated
Show resolved
Hide resolved
...-test/application-analytics-test-docker/src/test/it/xwiki/analytics/test/ui/AnalyticsIT.java
Outdated
Show resolved
Hide resolved
...test-pageobjects/src/main/java/com/xwiki/analytics/test/po/MostViewedPagesMacroViewPage.java
Outdated
Show resolved
Hide resolved
...n-analytics-test-pageobjects/src/main/java/com/xwiki/analytics/test/po/HomePageEditPage.java
Outdated
Show resolved
Hide resolved
mflorea
requested changes
Jan 11, 2024
application-analytics-test/application-analytics-test-docker/pom.xml
Outdated
Show resolved
Hide resolved
application-analytics-test/application-analytics-test-docker/pom.xml
Outdated
Show resolved
Hide resolved
|
|
||
| public class Config | ||
| { | ||
| public static final String DB_CONTAINER_NAME = "farcasut/custom-mysql:latest"; |
Contributor
There was a problem hiding this comment.
Long term we should move the container to an xwikisas account on Docker Hub.
...n-analytics-test-pageobjects/src/main/java/com/xwiki/analytics/test/po/HomePageViewPage.java
Outdated
Show resolved
Hide resolved
...tion-analytics-test-pageobjects/src/main/java/com/xwiki/analytics/test/po/AdminViewPage.java
Outdated
Show resolved
Hide resolved
...tion-analytics-test-pageobjects/src/main/java/com/xwiki/analytics/test/po/AdminViewPage.java
Outdated
Show resolved
Hide resolved
...tion-analytics-test-pageobjects/src/main/java/com/xwiki/analytics/test/po/AdminViewPage.java
Outdated
Show resolved
Hide resolved
...tion-analytics-test-pageobjects/src/main/java/com/xwiki/analytics/test/po/AdminViewPage.java
Outdated
Show resolved
Hide resolved
…hat everything works properly
…it easier to select it.
Added a FindBy to select the elements in the config tab Removed unnecessary imports Renamed classes Modified the URL of the rowevolution request to have the get action insted of the view
Added a wait to avoid flickering
Farcasut
force-pushed
the
functionalTests
branch
2 times, most recently
from
7f090f7 to
05114fe
Compare
oanalavinia
requested changes
Feb 28, 2024
...t/application-analytics-test-docker/src/test/it/com/xwiki/analytics/test/ui/AnalyticsIT.java
Outdated
Show resolved
Hide resolved
...t/application-analytics-test-docker/src/test/it/com/xwiki/analytics/test/ui/AnalyticsIT.java
Outdated
Show resolved
Hide resolved
...t/application-analytics-test-docker/src/test/it/com/xwiki/analytics/test/ui/AnalyticsIT.java
Outdated
Show resolved
Hide resolved
...t/application-analytics-test-docker/src/test/it/com/xwiki/analytics/test/ui/AnalyticsIT.java
Outdated
Show resolved
Hide resolved
...t/application-analytics-test-docker/src/test/it/com/xwiki/analytics/test/ui/AnalyticsIT.java
Outdated
Show resolved
Hide resolved
...t/application-analytics-test-docker/src/test/it/com/xwiki/analytics/test/ui/AnalyticsIT.java
Outdated
Show resolved
Hide resolved
...-analytics-test-pageobjects/src/main/java/com/xwiki/analytics/test/po/RowEvolutionModal.java
Outdated
Show resolved
Hide resolved
...-analytics-test-pageobjects/src/main/java/com/xwiki/analytics/test/po/RowEvolutionModal.java
Show resolved
Hide resolved
...ytics-test-pageobjects/src/main/java/com/xwiki/analytics/test/po/MostViewedPagesElement.java
Outdated
Show resolved
Hide resolved
...ytics-test-pageobjects/src/main/java/com/xwiki/analytics/test/po/MostViewedPagesElement.java
Outdated
Show resolved
Hide resolved
Refactored code, added a new test and improved formatted the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.