Add canonically-cased config options#1
Merged
xwjdsh merged 1 commit intoxwjdsh:masterfrom Feb 11, 2022
Merged
Conversation
701117d to
fa35f19
Compare
StephenBrown2
pushed a commit
to StephenBrown2/manssh
that referenced
this pull request
Feb 10, 2022
TODO: Remove reference to github.com/StephenBrown2/ssh_config when kevinburke/ssh_config#39 or xwjdsh/ssh_config#1 get merged
Owner
|
Thanks. |
Owner
|
I made a little polish on the basis of your changes. |
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a list of config options pulled from https://man.openbsd.org/ssh_config (an example function to re-pull the list is included as well, commented out), and adds a
KV.CanonicalKey()function, such that when printed with String(), the proper case is used for the Key, rather than all lowercase.Example:
Without this, when manssh prints:
the ~/.ssh/config file is also modified:
With this change, the case is preserved in the file, though printing still lowercases the keys.
NOTE: An identical PR has also been made upstream: kevinburke#39 so this can be closed if that one is merged in first.