feat: Pass general data to custom hotkey configs#540
Open
Heck-R wants to merge 2 commits intoxxxily:masterfrom
Open
feat: Pass general data to custom hotkey configs#540Heck-R wants to merge 2 commits intoxxxily:masterfrom
Heck-R wants to merge 2 commits intoxxxily:masterfrom
Conversation
Author
|
A specific example where I find this to be necessary/useful is overwriting the volume change from linear to "relative" (meaning the volume always changes by 10%, which is more consistent to the ears and is handy for lower volumes) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I love the possibility of custom configurations, but only site-specific ones seem to get detailed info on what's happening.
So this change is just that. It's a bit different from the site-specific one because this one is missing the player, but as the h5Player has an equivalent property it should not be necessary
I did not update the dist as I was not sure if I was supposed to be (I was also not sure how to do it properly)
To be fair this is more of a feature request than a pull request, I just implemented it so that I can use it immediately, and I thought I'd create a pull request from it in case it's of any help
Google Translated Chinese:
嗨,我喜欢自定义配置的可能性,但似乎只有特定于站点的配置才能获得有关正在发生的事情的详细信息。
所以这个变化就是这样。它与特定于站点的有点不同,因为这个缺少播放器,但由于 h5Player 具有等效属性,因此没有必要
我没有更新 dist,因为我不确定我是否应该更新(我也不确定如何正确地做)
公平地说,这更像是一个功能请求而不是拉取请求,我只是实现了它以便我可以立即使用它,我想我会从中创建一个拉取请求以防它有任何帮助