Skip to content

adds builds for macOS with ARM CPUs ("Apple Silicon"), and runs builds for each commit#34

Open
MichaelWhi wants to merge 3 commits intoxypwn:mainfrom
MichaelWhi:feature/apple-silicon-release
Open

adds builds for macOS with ARM CPUs ("Apple Silicon"), and runs builds for each commit#34
MichaelWhi wants to merge 3 commits intoxypwn:mainfrom
MichaelWhi:feature/apple-silicon-release

Conversation

@MichaelWhi
Copy link
Copy Markdown
Contributor

@MichaelWhi MichaelWhi commented Jun 3, 2025

I tried to run the macOS Intel release on my ARM Macbook, and macOS said the binary is not fine and it is suggested to recycle the file...
So I tried to compile your code, and it worked directly without any changes!
(Thanks btw for your awesome tool!)

This PR adds an Apple Silicon/macOS Release to your existing Intel/AMD64 releases. It also builds for all platforms for every push, since I needed to test the GH actions... and I think building for alle platforms is nice, anyway, for contributors.

@xypwn
Copy link
Copy Markdown
Owner

xypwn commented Jun 5, 2025

Thanks for the PR!
I wasn't aware that GitHub finally added MacOS ARM, so this is a very welcome change :)
I also think releasing for every branch is very sensible.

Just so I understand more clearly, did you test the ARM binary generated by GH actions on your computer, or did you build it locally? I remember there being some issues with executable signing, but I don't own a mac, so I can't verify.

@xypwn xypwn changed the title adds builds for macOS with ARM CPUs ("Apple Silicon"), and runs builds (but no releases) for each commit adds builds for macOS with ARM CPUs ("Apple Silicon"), and runs builds for each commit Jun 5, 2025
@MichaelWhi
Copy link
Copy Markdown
Contributor Author

Thanks for reviewing... I only tried go build ./cmd/southpark-downloader-ui locally, since I am not fluent in Go/Fyne.
I tried to update the "build-all.sh", but am not sure whether it is used in your GitHub Actions... The arm64 download seems to not work when downloaded.

If you do not have a quick tip to fix this, I have to postpone debugging in order to read more about how fyne works and to then check how you use it in your build process and how you sign your executables.

@MichaelWhi MichaelWhi force-pushed the feature/apple-silicon-release branch from a5545a6 to 923fa6a Compare June 10, 2025 23:40
@xypwn
Copy link
Copy Markdown
Owner

xypwn commented Jun 11, 2025

Sorry for the confusion! build-all.sh is what I used to use before setting up GitHub actions. Everything currently used for the automatic builds is in .github/workflows.

This means the arm64 build isn't working for another reason. I'm sure there is some way to get an error message or something similar when running the executable. Again, I unfortunately can't do any of that myself without a mac.

@MichaelWhi
Copy link
Copy Markdown
Contributor Author

Just FYI a small update... (I will keep this in my head, but still do not have a solution for this problem atm.)

I have researched a little bit, and it seems that for a seamless macOS release, the app has to be notarized by Apple.
To do this, it has be to tied to an Apple Developer account (99$/year); and must be signed by the account owner.
This, without setup, does not work simply for open source software, since it is tied to an individual developer and thus should not be used for all build artifacts. It would work with Fyne and/or GitHub Actions, though, but should only be used if the repository owner is the Apple Developer account owner.
https://gregoryszorc.com/docs/apple-codesign/stable/apple_codesign_github_actions.html is a good introduction, for reference.

@xypwn
Copy link
Copy Markdown
Owner

xypwn commented Jul 24, 2025

It's not really worth it for me to pay that kind of money, since I have no foot in the Apple ecosystem and don't make any money from this project (and I'm not even sure this app complies with Apple's TOS).
This sucks for MacOS ARM users, though. So I'll keep it open in case you (or someone else) finds another solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants