Migrate near-field table cache from HDF5 to SQLite#18
Merged
Conversation
Replace h5py-based cache I/O with sqlite3 storage, remove h5py from dependencies, and add a regression test with a clearer error for legacy HDF5 cache files.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 52e4f9cdf6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Normalize NumPy scalar serialization for sqlite-backed cache kwargs and fail fast on cache miss or force_recompute in read-only mode to avoid unnecessary recomputation.
Owner
Author
|
Addressed both review comments in commit Changes made:
Validation on
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NearFieldInteractionTableManagerpersistence involumential/table_manager.pywith sqlite-backed storage (nearfield_cache,nearfield_cache_kwargs, andnearfield_cache_meta) while keeping existing.hdf5cache filenamesh5pydependency fromsetup.py,.test-conda-env-py3.yml, and.test-conda-env-py3-macos.ymltest/test_table_manager_sqlite_migration.pyand raise a clear runtime error when a legacy HDF5 cache file is opened with the new sqlite backendTesting
ipa:python -m pytest test/test_table_manager.py test/test_table_manager_sqlite_migration.py test/test_nearfield_potential_table.py test/test_nearfield_interaction_completeness.py -q(31 passed, 36 skipped)ipa:python -m pytest test/test_volume_fmm.py::test_volume_fmm_laplace -vv -xpasses for NVIDIA CUDA when run with the companion sumpy fix in fix: correct NVIDIA CUDA queue guard in run_opencl_fft inducer/sumpy#271