Open
Conversation
Collaborator
|
@stefan-iki Hey… thanks for your contribution. Did the tests pass for you? |
Author
Collaborator
Ah I see whats going on. There was an accidental merge of a dependabot PR. Let me retry. |
tsmith14
referenced
this pull request
in Benty/yrb
Aug 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Thanks for creating and maintaining y-rb project. 👏 I've stumbled upon the same - or similar - problem as described in #155 - in my case however I need to serialize/deserialize from XmlText instead of YText.
Can we copy paste solution from ytext.rs to yxml_text.rs? That's what I did in this pull request. I guess it would serve my needs, although I'm not familiar with rust and yrs/yjs stuff, so... I might have mixed things up. 🤷
What do you think?
Kind regards,