-
Notifications
You must be signed in to change notification settings - Fork 83
fix(lint): Remove deleted files from clang-tidy lint exceptions. #1203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lint): Remove deleted files from clang-tidy lint exceptions. #1203
Conversation
WalkthroughRemoved 12 file paths from the clang-tidy EXCLUDE_PATTERNS for the check-cpp-static-full task in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
…s-from-lint-exceptions
kirkrodrigues
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the PR title, how about:
fix(lint): Remove deleted files from clang-tidy lint exceptions.
Description
PR #1163 deleted several files, but failed to also remove those files from the list of lint exceptions. This PR follows up on those changes by also deleting those files from the lint exceptions.
We also remove two other deleted files,
test-error_handling.cppandtest-ffi_IrUnitHandlerInterface.cpp.Checklist
breaking change.
Validation performed
Summary by CodeRabbit