Skip to content

Conversation

@gibber9809
Copy link
Contributor

@gibber9809 gibber9809 commented Aug 14, 2025

Description

PR #1163 deleted several files, but failed to also remove those files from the list of lint exceptions. This PR follows up on those changes by also deleting those files from the lint exceptions.

We also remove two other deleted files, test-error_handling.cpp and test-ffi_IrUnitHandlerInterface.cpp.

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

  • N/A

Summary by CodeRabbit

  • Refactor
    • Expanded static analysis coverage by removing exclusions for 12 source/test files, enabling fuller clang-tidy checks. This increases automated code inspection surface to catch issues earlier and improve overall code quality and maintainability.

@gibber9809 gibber9809 requested a review from a team as a code owner August 14, 2025 15:23
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 14, 2025

Walkthrough

Removed 12 file paths from the clang-tidy EXCLUDE_PATTERNS for the check-cpp-static-full task in taskfiles/lint.yaml, causing those C++ sources and tests to be included in full static analysis. No source code or API declarations were changed.

Changes

Cohort / File(s) Summary of Changes
Lint configuration
taskfiles/lint.yaml
Removed 12 entries from clang-tidy EXCLUDE_PATTERNS for check-cpp-static-full: clp_s/search/clp_search/EncodedVariableInterpreter.cpp, clp_s/search/clp_search/EncodedVariableInterpreter.hpp, clp_s/search/clp_search/Grep.cpp, clp_s/search/clp_search/Grep.hpp, clp_s/search/clp_search/Query.cpp, clp_s/search/clp_search/Query.hpp, clp_s/VariableDecoder.cpp, clp_s/VariableDecoder.hpp, clp_s/VariableEncoder.cpp, clp_s/VariableEncoder.hpp, tests/test-ffi_IrUnitHandlerInterface.cpp, test-error_handling.cpp.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • kirkrodrigues
  • wraymo

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between f6929b0 and 2a067b3.

📒 Files selected for processing (1)
  • taskfiles/lint.yaml (0 hunks)
💤 Files with no reviewable changes (1)
  • taskfiles/lint.yaml
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@gibber9809 gibber9809 changed the title fix(lint): Remove files deleted in PR #1163 from lint exceptions. fix(lint): Remove deleted files from lint exceptions. Aug 19, 2025
Copy link
Member

@kirkrodrigues kirkrodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the PR title, how about:

fix(lint): Remove deleted files from clang-tidy lint exceptions.

@gibber9809 gibber9809 changed the title fix(lint): Remove deleted files from lint exceptions. fix(lint): Remove deleted files from clang-tidy lint exceptions. Aug 19, 2025
@gibber9809 gibber9809 merged commit 76db060 into y-scope:main Aug 19, 2025
22 checks passed
@gibber9809 gibber9809 deleted the remove-deleted-files-from-lint-exceptions branch August 19, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants