Skip to content

build(deps): Install version-constrained dev tools via pipx rather than brew formulae on macOS; Bump minimum Boost version to 1.89 (fixes #1218, #1223). #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Aug 18, 2025
Merged

build(deps): Install version-constrained dev tools via pipx rather than brew formulae on macOS; Bump minimum Boost version to 1.89 (fixes #1218, #1223). #1219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
9df82fc
check brew version
Bill-hbrhbr Aug 18, 2025
38e2b9b
test brew tap
Bill-hbrhbr Aug 18, 2025
6db9350
Update tap name
Bill-hbrhbr Aug 18, 2025
6e7ddf6
Fix
Bill-hbrhbr Aug 18, 2025
0dd06d6
Fix
Bill-hbrhbr Aug 18, 2025
7c5f47f
Fix
Bill-hbrhbr Aug 18, 2025
b5f9327
Merge branch 'main' into check-brew-version
Bill-hbrhbr Aug 18, 2025
e82427d
Test brew version upgrade
Bill-hbrhbr Aug 18, 2025
5be9bf7
Revert checking brew version
Bill-hbrhbr Aug 18, 2025
22f70b5
use pipx to install cmake 3.31
Bill-hbrhbr Aug 18, 2025
f3e9a4a
Use pipx to install fixed-version deps
Bill-hbrhbr Aug 18, 2025
8a017cf
Fixiate versions
Bill-hbrhbr Aug 18, 2025
67ac678
Install approx versions
Bill-hbrhbr Aug 18, 2025
3410a7a
Fix boost version to 1.87.0
Bill-hbrhbr Aug 18, 2025
772c2e2
Try Boost 1.85
Bill-hbrhbr Aug 18, 2025
25f47df
Fix Boost version to 1.89 (consistent with MacOS) and remove Boost::s…
Bill-hbrhbr Aug 18, 2025
3d70048
Update components/core/CMakeLists.txt
Bill-hbrhbr Aug 18, 2025
04e3a56
For all dev tools, do brew uninstall and pipx install
Bill-hbrhbr Aug 18, 2025
c8e344f
Address offline review comments
Bill-hbrhbr Aug 18, 2025
e23fbb3
Use correct indentation
Bill-hbrhbr Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/core/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ if(CLP_NEED_BOOST)
if(CLP_USE_STATIC_LIBS)
set(Boost_USE_STATIC_LIBS ON)
endif()
find_package(Boost 1.81 REQUIRED iostreams program_options filesystem system regex url)
find_package(Boost 1.89 REQUIRED iostreams program_options filesystem regex url)
if(Boost_FOUND)
message(STATUS "Found Boost ${Boost_VERSION}")
else()
Expand Down
1 change: 0 additions & 1 deletion components/core/src/reducer/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ if(CLP_BUILD_EXECUTABLES)
target_link_libraries(reducer-server
PRIVATE
Boost::program_options
Boost::system
clp::string_utils
fmt::fmt
${MONGOCXX_TARGET}
Expand Down
2 changes: 1 addition & 1 deletion components/core/tools/scripts/lib_install/centos-stream-9/install-packages-from-source.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ script_dir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )"
lib_install_scripts_dir="${script_dir}/.."

# NOTE: The remaining installation scripts depend on boost, so we install it beforehand.
"${lib_install_scripts_dir}/install-boost.sh" 1.87.0
"${lib_install_scripts_dir}/install-boost.sh" 1.89.0

"${lib_install_scripts_dir}/liblzma.sh" 5.8.1
"${lib_install_scripts_dir}/msgpack.sh" 7.0.0
33 changes: 10 additions & 23 deletions components/core/tools/scripts/lib_install/macos/install-all.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,37 +8,24 @@ set -u

brew update

formula_dir="$(mktemp -d -t "clp-dep-formulas")"

# Install CMake v3.31.6 as ANTLR and yaml-cpp do not yet support CMake v4+.
# See also: https://github.com/y-scope/clp/issues/795
cmake_formula_path="${formula_dir}/cmake.rb"
curl \
--fail \
--location \
--output "$cmake_formula_path" \
--show-error \
https://raw.githubusercontent.com/Homebrew/homebrew-core/b4e46db74e74a8c1650b38b1da222284ce1ec5ce\
/Formula/c/cmake.rb
brew install --formula "$cmake_formula_path"
if command -v cmake ; then
brew uninstall --force cmake
fi
pipx install "cmake~=3.31"

# Install a version of `task` < 3.43 to avoid https://github.com/y-scope/clp/issues/872
task_formula_path="${formula_dir}/go-task.rb"
curl \
--fail \
--location \
--output "$task_formula_path" \
--show-error \
https://raw.githubusercontent.com/Homebrew/homebrew-core/356f8408263b6a06e8f5f83cad574773d8054e1c\
/Formula/g/go-task.rb
brew install --formula "$task_formula_path"
if command -v task ; then
brew uninstall --force task
fi
pipx install "go-task-bin>=3.40,<3.43"

# Install uv
if ! command -v uv ; then
brew install uv
pipx install "uv>=0.8"
fi

rm -rf "$formula_dir"

brew install \
boost \
coreutils \
Expand Down
2 changes: 1 addition & 1 deletion components/core/tools/scripts/lib_install/manylinux_2_28/install-packages-from-source.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ script_dir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )"
lib_install_scripts_dir="${script_dir}/.."

# NOTE: The remaining installation scripts depend on boost, so we install it beforehand.
"${lib_install_scripts_dir}/install-boost.sh" 1.87.0
"${lib_install_scripts_dir}/install-boost.sh" 1.89.0

# NOTE:
# 1. libarchive may statically link with LZMA, LZ4, and Zstandard, so we install them beforehand.
Expand Down
2 changes: 1 addition & 1 deletion components/core/tools/scripts/lib_install/musllinux_1_2/install-packages-from-source.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ script_dir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )"
lib_install_scripts_dir="${script_dir}/.."

# NOTE: The remaining installation scripts depend on boost, so we install it beforehand.
"${lib_install_scripts_dir}/install-boost.sh" 1.87.0
"${lib_install_scripts_dir}/install-boost.sh" 1.89.0

# NOTE:
# 1. libarchive may statically link with LZMA, LZ4, and Zstandard, so we install them beforehand.
Expand Down
2 changes: 1 addition & 1 deletion components/core/tools/scripts/lib_install/ubuntu-jammy/install-packages-from-source.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ script_dir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )"
lib_install_scripts_dir=$script_dir/..

# NOTE: boost must be installed first since the remaining packages depend on it
"$lib_install_scripts_dir"/install-boost.sh 1.87.0
"$lib_install_scripts_dir"/install-boost.sh 1.89.0

"$lib_install_scripts_dir"/libarchive.sh 3.5.1
"$lib_install_scripts_dir"/liblzma.sh 5.8.1
Expand Down
2 changes: 1 addition & 1 deletion docs/src/dev-guide/contributing-linting.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ To run the linting tools, besides commonly installed tools like `tar`, you'll ne
* [Task] >= 3.40.0 and < 3.43.0
* Minimum version 3.40.0 is required for [yscope-dev-utils].
* We constrain the version to < 3.43.0 due to unresolved [issues][clp-issue-872].
* [uv] >= 0.7.10
* [uv] >= 0.8

## Running the linters

Expand Down
Loading