-
Notifications
You must be signed in to change notification settings - Fork 83
build(deps): Bump ystdlib to y-scope/ystdlib-cpp@9ed78cd and install ystdlib via CMake; Lower minimum Clang version for Velox compatibility.
#1226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 14 commits
d4b0ae6
fb11954
32f8072
59c6b98
8a7e9c4
9bffe7a
5ce0f24
43a8cd7
7d194d1
d719bba
550bb4b
31646db
b96e4d1
2d0e114
01c8a2d
d6add9f
73f7fd1
029b33d
8467263
e6eb8a8
b7f67f6
4ca4f6f
141276f
acc4a62
f1c7024
81d6799
bdb75bb
373d43f
7f8706e
b5da810
39d7abb
916a4b6
06a9020
0157ac4
b6f1436
93bee22
22cfccc
8adc4e6
ff98538
bff7064
6224601
828e634
386e5dc
6f5579b
b674025
bc976fe
8d463fd
d68ddba
06d2ca8
d3b9b24
cee4c35
e6043ad
2e2e9c8
4141831
fc2fd9a
096d21c
54e18e0
1c34970
79c3756
856c06f
e0950c1
b833729
778fdac
26a3a10
8fec8ba
bbf21fc
8601b81
330c0ae
a09f934
0e94674
5c49e2b
627d024
a5930d6
ec611c5
e7a42bc
58b8688
c359e30
0730260
f4a2c53
627d440
b686138
8c5b4a7
9d48db5
848e5f9
92d6cd9
fc783cd
e29b90c
8c94fbd
0c5dce1
d928f5e
f8bde46
132c3b5
e70f2e7
bd528a7
cf30eea
d26a13f
e890c0e
81a0c1f
1ed15ec
56a9a54
d457236
8aff56e
c395102
055a573
57df29e
31b21c5
9297f67
c1ab120
b417e1d
a73e389
52119c7
34753ba
a7ab3d8
0b28635
57c51c9
9d66322
df085d1
6d2dc5d
0f4530f
d1a86db
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -45,6 +45,8 @@ jobs: | |
| strategy: | ||
| matrix: | ||
| os: | ||
| - "macos-13" | ||
| - "macos-14" | ||
| - "macos-15" | ||
| use_shared_libs: | ||
| - true | ||
|
|
||
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,29 +23,18 @@ dnf install -y \ | |
| python3-pip \ | ||
| unzip | ||
|
|
||
| # Determine architecture for `task` release to install | ||
| rpm_arch=$(rpm --eval "%{_arch}") | ||
| case "$rpm_arch" in | ||
| "x86_64") | ||
| task_pkg_arch="amd64" | ||
| ;; | ||
| "aarch64") | ||
| task_pkg_arch="arm64" | ||
| ;; | ||
| *) | ||
| echo "Error: Unsupported architecture - $rpm_arch" | ||
| exit 1 | ||
| ;; | ||
| esac | ||
| python3 -m pip install --user pipx | ||
|
|
||
| # Install `task` | ||
| # NOTE: We lock `task` to a version < 3.43 to avoid https://github.com/y-scope/clp/issues/872 | ||
| task_pkg_path="$(mktemp -t --suffix ".rpm" task-pkg.XXXXXXXXXX)" | ||
| curl \ | ||
| --fail \ | ||
| --location \ | ||
| --output "$task_pkg_path" \ | ||
| --show-error \ | ||
| "https://github.com/go-task/task/releases/download/v3.42.1/task_linux_${task_pkg_arch}.rpm" | ||
| dnf install --assumeyes "$task_pkg_path" | ||
| rm "$task_pkg_path" | ||
| # Install CMake v3.31.6 as ANTLR and yaml-cpp do not yet support CMake v4+. | ||
| # See also: https://github.com/y-scope/clp/issues/795 | ||
| if command -v cmake ; then | ||
| dnf remove -y cmake | ||
| fi | ||
| pipx install "cmake~=3.31" | ||
|
|
||
| # Install a version of `task` < 3.43 to avoid https://github.com/y-scope/clp/issues/872 | ||
| if command -v task ; then | ||
| echo "placeholder" | ||
| exit 1 | ||
| fi | ||
| pipx install "go-task-bin>=3.40,<3.43" | ||
|
||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -21,22 +21,24 @@ DEBIAN_FRONTEND=noninteractive apt-get install --no-install-recommends -y \ | |||||||||||||||||||||||||||||||||||||||||||||
| libmariadb-dev \ | ||||||||||||||||||||||||||||||||||||||||||||||
| libssl-dev \ | ||||||||||||||||||||||||||||||||||||||||||||||
| openjdk-11-jdk \ | ||||||||||||||||||||||||||||||||||||||||||||||
| pipx \ | ||||||||||||||||||||||||||||||||||||||||||||||
coderabbitai[bot] marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||||||||||||||||||||||||||||||||||||||||||
| pkg-config \ | ||||||||||||||||||||||||||||||||||||||||||||||
| python3 \ | ||||||||||||||||||||||||||||||||||||||||||||||
| python3-pip \ | ||||||||||||||||||||||||||||||||||||||||||||||
| python3-venv \ | ||||||||||||||||||||||||||||||||||||||||||||||
| software-properties-common \ | ||||||||||||||||||||||||||||||||||||||||||||||
| unzip | ||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||
| # Install `task` | ||||||||||||||||||||||||||||||||||||||||||||||
| # NOTE: We lock `task` to a version < 3.43 to avoid https://github.com/y-scope/clp/issues/872 | ||||||||||||||||||||||||||||||||||||||||||||||
| task_pkg_arch=$(dpkg --print-architecture) | ||||||||||||||||||||||||||||||||||||||||||||||
| task_pkg_path="$(mktemp -t --suffix ".deb" task-pkg.XXXXXXXXXX)" | ||||||||||||||||||||||||||||||||||||||||||||||
| curl \ | ||||||||||||||||||||||||||||||||||||||||||||||
| --fail \ | ||||||||||||||||||||||||||||||||||||||||||||||
| --location \ | ||||||||||||||||||||||||||||||||||||||||||||||
| --output "$task_pkg_path" \ | ||||||||||||||||||||||||||||||||||||||||||||||
| --show-error \ | ||||||||||||||||||||||||||||||||||||||||||||||
| "https://github.com/go-task/task/releases/download/v3.42.1/task_linux_${task_pkg_arch}.deb" | ||||||||||||||||||||||||||||||||||||||||||||||
| dpkg --install "$task_pkg_path" | ||||||||||||||||||||||||||||||||||||||||||||||
| rm "$task_pkg_path" | ||||||||||||||||||||||||||||||||||||||||||||||
| # Install CMake v3.31.6 as ANTLR and yaml-cpp do not yet support CMake v4+. | ||||||||||||||||||||||||||||||||||||||||||||||
| # See also: https://github.com/y-scope/clp/issues/795 | ||||||||||||||||||||||||||||||||||||||||||||||
| if command -v cmake ; then | ||||||||||||||||||||||||||||||||||||||||||||||
| apt-get purge -y cmake | ||||||||||||||||||||||||||||||||||||||||||||||
| fi | ||||||||||||||||||||||||||||||||||||||||||||||
| pipx install "cmake~=3.31" | ||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||
| # Install a version of `task` < 3.43 to avoid https://github.com/y-scope/clp/issues/872 | ||||||||||||||||||||||||||||||||||||||||||||||
| if command -v task ; then | ||||||||||||||||||||||||||||||||||||||||||||||
| echo "placeholder" | ||||||||||||||||||||||||||||||||||||||||||||||
| exit 1 | ||||||||||||||||||||||||||||||||||||||||||||||
| fi | ||||||||||||||||||||||||||||||||||||||||||||||
| pipx install "go-task-bin>=3.40,<3.43" | ||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||
| # Install a version of `task` < 3.43 to avoid https://github.com/y-scope/clp/issues/872 | |
| if command -v task ; then | |
| echo "placeholder" | |
| exit 1 | |
| fi | |
| pipx install "go-task-bin>=3.40,<3.43" | |
| # Install a version of `task` < 3.43 to avoid https://github.com/y-scope/clp/issues/872 | |
| if command -v task ; then | |
| echo "task already present; skipping install." | |
| else | |
| : "${PIPX_BIN_DIR:=/usr/local/bin}" | |
| : "${PIPX_HOME:=/opt/pipx}" | |
| mkdir -p "$PIPX_HOME" "$PIPX_BIN_DIR" | |
| pipx install --force "go-task-bin>=3.40,<3.43" | |
| fi | |
| # Sanity check: ensure task is on PATH and within allowed range | |
| if ! command -v task >/dev/null ; then | |
| echo "task not found on PATH (${PIPX_BIN_DIR})." >&2 | |
| exit 1 | |
| fi | |
| task --version | |
| task --version | grep -E '[Vv]?3\.4[0-2]\.' >/dev/null |
🤖 Prompt for AI Agents
In
components/core/tools/scripts/lib_install/ubuntu-jammy/install-prebuilt-packages.sh
around lines 39-44, remove the placeholder echo + exit and instead skip
reinstall when a suitable task binary already exists: check if command -v task
returns true and that task --version reports <3.43, and only proceed when
missing or out-of-range. When installing, invoke pipx with a hardened/shim path
(set PIPX_BIN_DIR to a global location like /usr/local/bin or the project
standard pipx bin dir) and use pipx install "go-task-bin>=3.40,<3.43" (use
--force if you need to upgrade), then add a post-install version guard that runs
task --version and exits nonzero if the installed version is >=3.43 to prevent
regressions from yanked versions.
Uh oh!
There was an error while loading. Please reload this page.