-
Notifications
You must be signed in to change notification settings - Fork 83
build(deps): Bump ystdlib to y-scope/ystdlib-cpp@9ed78cd and install ystdlib via CMake; Lower minimum Clang version for Velox compatibility.
#1226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 9 commits
d4b0ae6
fb11954
32f8072
59c6b98
8a7e9c4
9bffe7a
5ce0f24
43a8cd7
7d194d1
d719bba
550bb4b
31646db
b96e4d1
2d0e114
01c8a2d
d6add9f
73f7fd1
029b33d
8467263
e6eb8a8
b7f67f6
4ca4f6f
141276f
acc4a62
f1c7024
81d6799
bdb75bb
373d43f
7f8706e
b5da810
39d7abb
916a4b6
06a9020
0157ac4
b6f1436
93bee22
22cfccc
8adc4e6
ff98538
bff7064
6224601
828e634
386e5dc
6f5579b
b674025
bc976fe
8d463fd
d68ddba
06d2ca8
d3b9b24
cee4c35
e6043ad
2e2e9c8
4141831
fc2fd9a
096d21c
54e18e0
1c34970
79c3756
856c06f
e0950c1
b833729
778fdac
26a3a10
8fec8ba
bbf21fc
8601b81
330c0ae
a09f934
0e94674
5c49e2b
627d024
a5930d6
ec611c5
e7a42bc
58b8688
c359e30
0730260
f4a2c53
627d440
b686138
8c5b4a7
9d48db5
848e5f9
92d6cd9
fc783cd
e29b90c
8c94fbd
0c5dce1
d928f5e
f8bde46
132c3b5
e70f2e7
bd528a7
cf30eea
d26a13f
e890c0e
81a0c1f
1ed15ec
56a9a54
d457236
8aff56e
c395102
055a573
57df29e
31b21c5
9297f67
c1ab120
b417e1d
a73e389
52119c7
34753ba
a7ab3d8
0b28635
57c51c9
9d66322
df085d1
6d2dc5d
0f4530f
d1a86db
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -45,6 +45,8 @@ jobs: | |
| strategy: | ||
| matrix: | ||
| os: | ||
| - "macos-13" | ||
| - "macos-14" | ||
| - "macos-15" | ||
| use_shared_libs: | ||
| - true | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -31,6 +31,15 @@ jobs: | |||||||||||||||||||||||
| with: | ||||||||||||||||||||||||
| python-version: "3.11" | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| - if: "matrix.os == 'ubuntu24.04'" | ||||||||||||||||||||||||
| name: "Install pipx" | ||||||||||||||||||||||||
| shell: "bash" | ||||||||||||||||||||||||
| run: "DEBIAN_FRONTEND=noninteractive apt-get install --no-install-recommends -y pipx" | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
|
||||||||||||||||||||||||
| - if: "matrix.os == 'ubuntu24.04'" | |
| name: "Install pipx" | |
| shell: "bash" | |
| run: "DEBIAN_FRONTEND=noninteractive apt-get install --no-install-recommends -y pipx" | |
| - if: startsWith(matrix.os, 'ubuntu-') | |
| name: "Install pipx (Ubuntu)" | |
| shell: bash | |
| run: | | |
| sudo apt-get update | |
| DEBIAN_FRONTEND=noninteractive sudo apt-get install --no-install-recommends -y pipx |
🤖 Prompt for AI Agents
.github/workflows/clp-lint.yaml around lines 34 to 38: the job condition
incorrectly matches "ubuntu24.04" (missing dash) so the pipx install step never
runs; update the if expression to check matrix.os == 'ubuntu-24.04' and make the
install robust by running apt-get update and using sudo for apt-get install
(e.g., run: sudo apt-get update && sudo DEBIAN_FRONTEND=noninteractive apt-get
install --no-install-recommends -y pipx), ensuring the step executes on the
intended Ubuntu runner and succeeds on GitHub-hosted images.
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Unconditional cmake install via pipx will fail on macOS (pipx not present)
This step assumes pipx exists on all runners. Given the previous step is Ubuntu-only, macOS lacks pipx and the cmake install will fail.
Option A (OS-specific installs; minimal diff with current approach):
- - name: "Install cmake"
- shell: "bash"
- run: "pipx install cmake~=3.31"
+ - if: startsWith(matrix.os, 'macos-')
+ name: "Install pipx (macOS)"
+ shell: bash
+ run: brew install pipx
+
+ - name: "Install CMake via pipx"
+ shell: bash
+ run: pipx install "cmake~=3.31"Option B (preferred; cross-platform and simpler): use the maintained setup action for pipx, then install cmake. Replace both the pipx installation and cmake steps with:
- - if: "matrix.os == 'ubuntu24.04'"
- name: "Install pipx"
- shell: "bash"
- run: "DEBIAN_FRONTEND=noninteractive apt-get install --no-install-recommends -y pipx"
-
- - name: "Install cmake"
- shell: "bash"
- run: "pipx install cmake~=3.31"
+ - name: "Set up pipx"
+ uses: pipx/actions/setup-pipx@<pin-a-specific-SHA>
+ - name: "Install CMake via pipx"
+ shell: bash
+ run: pipx install "cmake~=3.31"Note: align with your policy of pinning actions by commit SHA (replace accordingly). This keeps behaviour consistent across Ubuntu and macOS and avoids OS-conditional maintenance.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - name: "Install cmake" | |
| shell: "bash" | |
| run: "pipx install cmake~=3.31" | |
| - if: startsWith(matrix.os, 'macos-') | |
| name: "Install pipx (macOS)" | |
| shell: bash | |
| run: brew install pipx | |
| - name: "Install CMake via pipx" | |
| shell: bash | |
| run: pipx install "cmake~=3.31" |
🤖 Prompt for AI Agents
In .github/workflows/clp-lint.yaml around lines 39-42, the workflow
unconditionally runs "pipx install cmake~=3.31" which fails on macOS because
pipx isn't installed; replace the current pipx+cmeake steps with a
cross-platform approach: add the maintained pipx setup action (pinned to a
specific commit SHA) before any pipx commands, then run pipx install cmake after
that, or alternately use OS-specific install steps (install pipx on
macOS/Ubuntu) — ensure the action is pinned by commit SHA and remove the
unconditional pipx install so the job succeeds on macOS and Ubuntu.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.