Skip to content

fix(docker): Ignore errors from clp-package dev image removal (fixes #1370). #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(docker): Ignore errors from clp-package dev image removal (fixes #1370). #1372

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
197b5a3
fix(docker): Ignore errors from clp-package dev image removal (fixes …
junhaoliao Oct 2, 2025
f99198b
Merge branch 'main' into graceful-image-removal
junhaoliao Oct 15, 2025
71db085
Merge branch 'main' into graceful-image-removal
junhaoliao Oct 20, 2025
bcc6dfe
Merge branch 'main' into graceful-image-removal
junhaoliao Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tools/docker-images/clp-package/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ remove_temp_file_and_prev_image() {

[[ -z "$prev_image_id" || "$prev_image_id" == "$new_image_id" ]] && return

if docker image inspect "$prev_image_id" >/dev/null 2>&1; then
echo "Removing previous image $prev_image_id."
docker image remove "$prev_image_id"
fi
docker image inspect "$prev_image_id" >/dev/null 2>&1 || return

echo "Removing previous image $prev_image_id."
docker image remove "$prev_image_id" || true
}
trap remove_temp_file_and_prev_image EXIT

Expand Down
Loading