refactor(taskfile): Split main dependency Taskfile into category-specific modules; Migrate antlr-runtime and utfcpp to use utils:install-remote-cmake-lib.
#1377
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,365 @@ | ||||||||
| version: "3" | ||||||||
|
|
||||||||
| vars: | ||||||||
| # Library names | ||||||||
| G_BOOST_LIB_NAME: "Boost" | ||||||||
| G_FMT_LIB_NAME: "fmt" | ||||||||
| G_GSL_LIB_NAME: "Microsoft.GSL" | ||||||||
|
|
||||||||
| # NOTE: For dependencies built using CMake, we set CMP0074 to NEW whenever: | ||||||||
| # - a component's minimum required CMake version is less than 3.27 (where CMP0074 defaults to OLD); | ||||||||
| # and | ||||||||
| # - the component depends on another via `<lib_name>_ROOT`. | ||||||||
| tasks: | ||||||||
| absl: | ||||||||
| internal: true | ||||||||
| run: "once" | ||||||||
| cmds: | ||||||||
| - task: "utils:install-remote-cmake-lib" | ||||||||
| vars: | ||||||||
| CMAKE_GEN_ARGS: | ||||||||
| - "-DCMAKE_BUILD_TYPE=Release" | ||||||||
Bill-hbrhbr marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||||
| - "-DCMAKE_CXX_STANDARD=20" | ||||||||
| - "-DCMAKE_INSTALL_MESSAGE=LAZY" | ||||||||
| LIB_NAME: "absl" | ||||||||
| TARBALL_SHA256: "7262daa7c1711406248c10f41026d685e88223bc92817d16fb93c19adb57f669" | ||||||||
| TARBALL_URL: "https://github.com/abseil/abseil-cpp/releases/download/20250512.0/\ | ||||||||
| abseil-cpp-20250512.0.tar.gz" | ||||||||
|
|
||||||||
| catch2: | ||||||||
| internal: true | ||||||||
| run: "once" | ||||||||
| cmds: | ||||||||
| - task: "utils:install-remote-cmake-lib" | ||||||||
| vars: | ||||||||
| CMAKE_GEN_ARGS: | ||||||||
| - "-DBUILD_TESTING=OFF" | ||||||||
| - "-DCMAKE_BUILD_TYPE=Release" | ||||||||
| - "-DCMAKE_CXX_STANDARD=20" | ||||||||
| - "-DCMAKE_CXX_STANDARD_REQUIRED=ON" | ||||||||
| - "-DCMAKE_INSTALL_MESSAGE=LAZY" | ||||||||
| LIB_NAME: "Catch2" | ||||||||
| TARBALL_SHA256: "1ab2de20460d4641553addfdfe6acd4109d871d5531f8f519a52ea4926303087" | ||||||||
| TARBALL_URL: "https://github.com/catchorg/Catch2/archive/refs/tags/v3.8.0.tar.gz" | ||||||||
|
|
||||||||
| date: | ||||||||
| internal: true | ||||||||
| run: "once" | ||||||||
| cmds: | ||||||||
| - task: "utils:install-remote-cmake-lib" | ||||||||
| vars: | ||||||||
| CMAKE_GEN_ARGS: | ||||||||
| - "-DCMAKE_BUILD_TYPE=Release" | ||||||||
| - "-DCMAKE_INSTALL_MESSAGE=LAZY" | ||||||||
Bill-hbrhbr marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||||
| LIB_NAME: "date" | ||||||||
| TARBALL_SHA256: "7a390f200f0ccd207e8cff6757e04817c1a0aec3e327b006b7eb451c57ee3538" | ||||||||
| TARBALL_URL: "https://github.com/HowardHinnant/date/archive/refs/tags/v3.0.1.tar.gz" | ||||||||
|
|
||||||||
| fmt: | ||||||||
| internal: true | ||||||||
| run: "once" | ||||||||
| cmds: | ||||||||
| - task: "utils:install-remote-cmake-lib" | ||||||||
| vars: | ||||||||
| CMAKE_GEN_ARGS: | ||||||||
| - "-DCMAKE_BUILD_TYPE=Release" | ||||||||
| - "-DCMAKE_INSTALL_MESSAGE=LAZY" | ||||||||
| - "-DFMT_DOC=OFF" | ||||||||
| - "-DFMT_TEST=OFF" | ||||||||
| LIB_NAME: "{{.G_FMT_LIB_NAME}}" | ||||||||
| TARBALL_SHA256: "bc23066d87ab3168f27cef3e97d545fa63314f5c79df5ea444d41d56f962c6af" | ||||||||
| TARBALL_URL: "https://github.com/fmtlib/fmt/archive/refs/tags/11.2.0.tar.gz" | ||||||||
|
|
||||||||
| liblzma: | ||||||||
| internal: true | ||||||||
| vars: | ||||||||
| COMMON_CMAKE_GEN_ARGS: | ||||||||
Bill-hbrhbr marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||||
| - "-DBUILD_TESTING=OFF" | ||||||||
| - "-DCMAKE_BUILD_TYPE=Release" | ||||||||
| - "-DCMAKE_INSTALL_MESSAGE=LAZY" | ||||||||
| - "-DXZ_DOC=OFF" | ||||||||
| - "-DXZ_TOOL_LZMADEC=OFF" | ||||||||
| - "-DXZ_TOOL_LZMAINFO=OFF" | ||||||||
| - "-DXZ_TOOL_SCRIPTS=OFF" | ||||||||
| - "-DXZ_TOOL_SYMLINKS_LZMA=OFF" | ||||||||
| - "-DXZ_TOOL_XZ=OFF" | ||||||||
| - "-DXZ_TOOL_XZDEC=OFF" | ||||||||
| TARBALL_SHA256: "507825b599356c10dca1cd720c9d0d0c9d5400b9de300af00e4d1ea150795543" | ||||||||
| TARBALL_URL: "https://github.com/tukaani-project/xz/releases/download/v5.8.1/xz-5.8.1.tar.gz" | ||||||||
| run: "once" | ||||||||
| deps: | ||||||||
| - task: "liblzma-install" | ||||||||
| vars: | ||||||||
| BUILD_SHARED_LIBS: true | ||||||||
| COMMON_CMAKE_GEN_ARGS: | ||||||||
| ref: ".COMMON_CMAKE_GEN_ARGS" | ||||||||
Bill-hbrhbr marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||||
| TARBALL_SHA256: "{{.TARBALL_SHA256}}" | ||||||||
| TARBALL_URL: "{{.TARBALL_URL}}" | ||||||||
| - task: "liblzma-install" | ||||||||
| vars: | ||||||||
| BUILD_SHARED_LIBS: false | ||||||||
| COMMON_CMAKE_GEN_ARGS: | ||||||||
| ref: ".COMMON_CMAKE_GEN_ARGS" | ||||||||
Bill-hbrhbr marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||||
| TARBALL_SHA256: "{{.TARBALL_SHA256}}" | ||||||||
| TARBALL_URL: "{{.TARBALL_URL}}" | ||||||||
Bill-hbrhbr marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||||
|
|
||||||||
| liblzma-install: | ||||||||
| internal: true | ||||||||
| requires: | ||||||||
| vars: ["BUILD_SHARED_LIBS", "COMMON_CMAKE_GEN_ARGS", "TARBALL_SHA256", "TARBALL_URL"] | ||||||||
Bill-hbrhbr marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||||
| cmds: | ||||||||
| - task: "utils:install-remote-cmake-lib" | ||||||||
| vars: | ||||||||
| CMAKE_GEN_ARGS: | ||||||||
| - "-DBUILD_SHARED_LIBS={{ if .BUILD_SHARED_LIBS }}ON{{ else }}OFF{{ end }}" | ||||||||
| - >- | ||||||||
| {{ join " " .COMMON_CMAKE_GEN_ARGS }} | ||||||||
Bill-hbrhbr marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||||
| LIB_NAME: "LibLZMA-{{ if .BUILD_SHARED_LIBS }}shared{{ else }}static{{ end }}" | ||||||||
| TARBALL_SHA256: "{{.TARBALL_SHA256}}" | ||||||||
| TARBALL_URL: "{{.TARBALL_URL}}" | ||||||||
Bill-hbrhbr marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||||
|
|
||||||||
| log-surgeon: | ||||||||
| internal: true | ||||||||
| run: "once" | ||||||||
| deps: | ||||||||
| - "fmt" | ||||||||
| - "microsoft.gsl" | ||||||||
| cmds: | ||||||||
| - task: "utils:install-remote-cmake-lib" | ||||||||
| vars: | ||||||||
| CMAKE_GEN_ARGS: | ||||||||
| - "-C {{.G_DEPS_CPP_CMAKE_SETTINGS_DIR}}/{{.G_FMT_LIB_NAME}}.cmake" | ||||||||
| - "-C {{.G_DEPS_CPP_CMAKE_SETTINGS_DIR}}/{{.G_GSL_LIB_NAME}}.cmake" | ||||||||
| - "-DCMAKE_BUILD_TYPE=Release" | ||||||||
| - "-DCMAKE_INSTALL_MESSAGE=LAZY" | ||||||||
| - "-Dlog_surgeon_BUILD_TESTING=OFF" | ||||||||
| LIB_NAME: "log_surgeon" | ||||||||
| TARBALL_SHA256: "69a99e0804a52c6b6397c5e7eabecc9bb4915d0145632c66fc63ad13678ff56a" | ||||||||
| TARBALL_URL: "https://github.com/y-scope/log-surgeon/archive/a722d07.tar.gz" | ||||||||
|
|
||||||||
| lz4: | ||||||||
| internal: true | ||||||||
| run: "once" | ||||||||
| cmds: | ||||||||
| - task: "utils:install-remote-cmake-lib" | ||||||||
| vars: | ||||||||
| CMAKE_GEN_ARGS: | ||||||||
| - "-DBUILD_SHARED_LIBS=ON" | ||||||||
| - "-DBUILD_STATIC_LIBS=ON" | ||||||||
| - "-DCMAKE_BUILD_TYPE=Release" | ||||||||
| - "-DCMAKE_INSTALL_MESSAGE=LAZY" | ||||||||
| - "-DLZ4_BUILD_CLI=OFF" | ||||||||
| CMAKE_SOURCE_DIR: "build/cmake" | ||||||||
| LIB_NAME: "lz4" | ||||||||
| TARBALL_SHA256: "537512904744b35e232912055ccf8ec66d768639ff3abe5788d90d792ec5f48b" | ||||||||
| TARBALL_URL: "https://github.com/lz4/lz4/releases/download/v1.10.0/lz4-1.10.0.tar.gz" | ||||||||
|
|
||||||||
| mariadb-connector-cpp: | ||||||||
| internal: true | ||||||||
| platforms: ["linux"] | ||||||||
| preconditions: | ||||||||
| # NOTE: The MariaDB connector is only required for building Spider, which is only supported on | ||||||||
| # Ubuntu. `INSTALL_LAYOUT` is currently hardcoded to "DEB". To support other Linux distros: | ||||||||
| # - Update the precondition accordingly. | ||||||||
| # - Make `INSTALL_LAYOUT` configurable. | ||||||||
| - >- | ||||||||
| source /etc/os-release && [[ "$ID" == "ubuntu" ]] | ||||||||
| run: "once" | ||||||||
Bill-hbrhbr marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||||
| cmds: | ||||||||
| - task: "utils:install-remote-cmake-lib" | ||||||||
| vars: | ||||||||
| CMAKE_GEN_ARGS: | ||||||||
| - "-DUSE_SYSTEM_INSTALLED_LIB=ON" | ||||||||
Bill-hbrhbr marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||||
| - "-DINSTALL_LAYOUT=DEB" | ||||||||
| LIB_NAME: "mariadb-connector-cpp" | ||||||||
| TARBALL_SHA256: "0e3dfe9f2bc3f7bb6f7c159009556290064a7c23402ea08019fa8aebfc3ff2c9" | ||||||||
| TARBALL_URL: "https://github.com/mariadb-corporation/mariadb-connector-cpp/archive/refs/\ | ||||||||
| tags/1.1.5.tar.gz" | ||||||||
|
|
||||||||
| microsoft.gsl: | ||||||||
| internal: true | ||||||||
| run: "once" | ||||||||
| cmds: | ||||||||
| - task: "utils:install-remote-cmake-lib" | ||||||||
| vars: | ||||||||
| CMAKE_GEN_ARGS: | ||||||||
| - "-DCMAKE_BUILD_TYPE=Release" | ||||||||
| - "-DCMAKE_INSTALL_MESSAGE=LAZY" | ||||||||
| - "-DGSL_TEST=OFF" | ||||||||
| LIB_NAME: "{{.G_GSL_LIB_NAME}}" | ||||||||
| TARBALL_SHA256: "f0e32cb10654fea91ad56bde89170d78cfbf4363ee0b01d8f097de2ba49f6ce9" | ||||||||
| TARBALL_URL: "https://github.com/microsoft/GSL/archive/refs/tags/v4.0.0.tar.gz" | ||||||||
|
|
||||||||
| mongocxx: | ||||||||
| internal: true | ||||||||
| vars: | ||||||||
| VERSION: "r4.1.1" | ||||||||
| run: "once" | ||||||||
| cmds: | ||||||||
| - task: "utils:install-remote-cmake-lib" | ||||||||
| vars: | ||||||||
| CMAKE_GEN_ARGS: | ||||||||
| - "-DBUILD_SHARED_AND_STATIC_LIBS=ON" | ||||||||
| - "-DBUILD_SHARED_LIBS_WITH_STATIC_MONGOC=ON" | ||||||||
Bill-hbrhbr marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||||
| - "-DCMAKE_BUILD_TYPE=Release" | ||||||||
| - "-DCMAKE_INSTALL_MESSAGE=LAZY" | ||||||||
| - "-DENABLE_UNINSTALL=OFF" | ||||||||
| LIB_NAME: "mongocxx" | ||||||||
| TARBALL_SHA256: "19dff3cf834a3e09229260f22a0325820a7e30c78b294db91794dd934776b33a" | ||||||||
| TARBALL_URL: "https://github.com/mongodb/mongo-cxx-driver/releases/download/{{.VERSION}}\ | ||||||||
| /mongo-cxx-driver-{{.VERSION}}.tar.gz" | ||||||||
|
|
||||||||
| msgpack-cxx: | ||||||||
| internal: true | ||||||||
| vars: | ||||||||
| VERSION: "7.0.0" | ||||||||
| run: "once" | ||||||||
| deps: | ||||||||
| - task: "boost" | ||||||||
| cmds: | ||||||||
| - task: "utils:install-remote-cmake-lib" | ||||||||
| vars: | ||||||||
| CMAKE_GEN_ARGS: | ||||||||
| - "-C {{.G_DEPS_CPP_CMAKE_SETTINGS_DIR}}/{{.G_BOOST_LIB_NAME}}.cmake" | ||||||||
| - "-DCMAKE_BUILD_TYPE=Release" | ||||||||
| - "-DCMAKE_INSTALL_MESSAGE=LAZY" | ||||||||
| - "-DCMAKE_POLICY_DEFAULT_CMP0074=NEW" | ||||||||
| - "-DMSGPACK_BUILD_DOCS=OFF" | ||||||||
Bill-hbrhbr marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||||
| - "-DMSGPACK_CXX20=ON" | ||||||||
| LIB_NAME: "msgpack-cxx" | ||||||||
| TARBALL_SHA256: "7504b7af7e7b9002ce529d4f941e1b7fb1fb435768780ce7da4abaac79bb156f" | ||||||||
| TARBALL_URL: "https://github.com/msgpack/msgpack-c/releases/download/cpp-{{.VERSION}}\ | ||||||||
| /msgpack-cxx-{{.VERSION}}.tar.gz" | ||||||||
Bill-hbrhbr marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||||
|
|
||||||||
| nlohmann_json: | ||||||||
| internal: true | ||||||||
| run: "once" | ||||||||
| cmds: | ||||||||
| - task: "utils:install-remote-cmake-lib" | ||||||||
| vars: | ||||||||
| CMAKE_GEN_ARGS: | ||||||||
| - "-DCMAKE_BUILD_TYPE=Release" | ||||||||
| - "-DCMAKE_INSTALL_MESSAGE=LAZY" | ||||||||
| - "-DJSON_BuildTests=OFF" | ||||||||
| LIB_NAME: "nlohmann_json" | ||||||||
| TARBALL_SHA256: "0d8ef5af7f9794e3263480193c491549b2ba6cc74bb018906202ada498a79406" | ||||||||
|
|
||||||||
| # NOTE: We use the GitHub-generated source tarball for this version rather than the | ||||||||
| # release tarball, since the latter is served from githubusercontent.com which is blocked | ||||||||
| # by some developers' firewalls. The contents of the former are a superset of the latter. | ||||||||
| TARBALL_URL: "https://github.com/nlohmann/json/archive/refs/tags/v3.11.3.tar.gz" | ||||||||
|
|
||||||||
| simdjson: | ||||||||
| internal: true | ||||||||
| run: "once" | ||||||||
| cmds: | ||||||||
| - task: "utils:install-remote-cmake-lib" | ||||||||
| vars: | ||||||||
| CMAKE_GEN_ARGS: | ||||||||
| - "-DCMAKE_BUILD_TYPE=Release" | ||||||||
Bill-hbrhbr marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||||
| - "-DCMAKE_INSTALL_MESSAGE=LAZY" | ||||||||
| LIB_NAME: "simdjson" | ||||||||
| TARBALL_SHA256: "07a1bb3587aac18fd6a10a83fe4ab09f1100ab39f0cb73baea1317826b9f9e0d" | ||||||||
| TARBALL_URL: "https://github.com/simdjson/simdjson/archive/refs/tags/v3.13.0.tar.gz" | ||||||||
|
|
||||||||
| spdlog: | ||||||||
| internal: true | ||||||||
| run: "once" | ||||||||
| deps: | ||||||||
| - "fmt" | ||||||||
| cmds: | ||||||||
| - task: "utils:install-remote-cmake-lib" | ||||||||
| vars: | ||||||||
| CMAKE_GEN_ARGS: | ||||||||
| - "-C {{.G_DEPS_CPP_CMAKE_SETTINGS_DIR}}/{{.G_FMT_LIB_NAME}}.cmake" | ||||||||
| - "-DCMAKE_BUILD_TYPE=Release" | ||||||||
| - "-DCMAKE_INSTALL_MESSAGE=LAZY" | ||||||||
| - "-DCMAKE_POLICY_DEFAULT_CMP0074=NEW" | ||||||||
| - "-DSPDLOG_BUILD_EXAMPLE=OFF" | ||||||||
| - "-DSPDLOG_BUILD_EXAMPLE_HO=OFF" | ||||||||
Bill-hbrhbr marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||||
| - "-DSPDLOG_FMT_EXTERNAL=ON" | ||||||||
Bill-hbrhbr marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||||
| LIB_NAME: "spdlog" | ||||||||
| TARBALL_SHA256: "15a04e69c222eb6c01094b5c7ff8a249b36bb22788d72519646fb85feb267e67" | ||||||||
|
|
||||||||
| # NOTE: Since spdlog depends on fmt, we need to choose a version of spdlog that's | ||||||||
| # compatible with the version of fmt we use. | ||||||||
| TARBALL_URL: "https://github.com/gabime/spdlog/archive/refs/tags/v1.15.3.tar.gz" | ||||||||
|
|
||||||||
| utfcpp: | ||||||||
| internal: true | ||||||||
| run: "once" | ||||||||
| cmds: | ||||||||
| - task: "utils:install-remote-cmake-lib" | ||||||||
| vars: | ||||||||
| CMAKE_GEN_ARGS: | ||||||||
| - "-DCMAKE_INSTALL_MESSAGE=LAZY" | ||||||||
Bill-hbrhbr marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||||
| LIB_NAME: "utfcpp" | ||||||||
| TARBALL_SHA256: "6920a6a5d6a04b9a89b2a89af7132f8acefd46e0c2a7b190350539e9213816c0" | ||||||||
| TARBALL_URL: "https://github.com/nemtrif/utfcpp/archive/refs/tags/v4.0.6.tar.gz" | ||||||||
|
|
||||||||
| yaml-cpp: | ||||||||
| internal: true | ||||||||
| run: "once" | ||||||||
| cmds: | ||||||||
| - task: "utils:install-remote-cmake-lib" | ||||||||
| vars: | ||||||||
| CMAKE_GEN_ARGS: | ||||||||
| - "-DBUILD_TESTING=OFF" | ||||||||
| - "-DCMAKE_BUILD_TYPE=Release" | ||||||||
| - "-DCMAKE_INSTALL_MESSAGE=LAZY" | ||||||||
| LIB_NAME: "yaml-cpp" | ||||||||
| TARBALL_SHA256: "43e6a9fcb146ad871515f0d0873947e5d497a1c9c60c58cb102a97b47208b7c3" | ||||||||
| TARBALL_URL: "https://github.com/jbeder/yaml-cpp/archive/refs/tags/yaml-cpp-0.7.0.tar.gz" | ||||||||
|
|
||||||||
| ystdlib: | ||||||||
| internal: true | ||||||||
| run: "once" | ||||||||
| deps: | ||||||||
| - task: "boost" | ||||||||
| cmds: | ||||||||
| - task: "utils:install-remote-cmake-lib" | ||||||||
| vars: | ||||||||
| CMAKE_GEN_ARGS: | ||||||||
| - "-C {{.G_DEPS_CPP_CMAKE_SETTINGS_DIR}}/{{.G_BOOST_LIB_NAME}}.cmake" | ||||||||
| - "-DCMAKE_POSITION_INDEPENDENT_CODE=ON" | ||||||||
| - "-Dystdlib_BUILD_TESTING=OFF" | ||||||||
| LIB_NAME: "ystdlib" | ||||||||
| TARBALL_SHA256: "65990dc2bcc4a355c2181bfe31a7800f492309d1bcd340f52a34e85047e61bc8" | ||||||||
| TARBALL_URL: "https://github.com/y-scope/ystdlib-cpp/archive/9ed78cd.tar.gz" | ||||||||
|
|
||||||||
| zlib: | ||||||||
| internal: true | ||||||||
| vars: | ||||||||
| LIB_NAME: "zlib" | ||||||||
| run: "once" | ||||||||
| cmds: | ||||||||
| - task: "utils:install-remote-cmake-lib" | ||||||||
| vars: | ||||||||
| CMAKE_GEN_ARGS: | ||||||||
| - "-DBUILD_SHARED_LIBS=ON" | ||||||||
| - "-DCMAKE_BUILD_TYPE=Release" | ||||||||
| - "-DCMAKE_INSTALL_MESSAGE=LAZY" | ||||||||
| - "-DCMAKE_INSTALL_PREFIX={{.G_DEPS_CPP_DIR}}/{{.LIB_NAME}}-install" | ||||||||
| - "-DZLIB_BUILD_EXAMPLES=OFF" | ||||||||
|
||||||||
| - "-DZLIB_BUILD_EXAMPLES=OFF" | |
| - "-DZLIB_BUILD_EXAMPLES=OFF" | |
| - "-DZLIB_BUILD_TESTING=OFF" |
Contributor
Author
There was a problem hiding this comment.
ZLIB_BUILD_TESTING is not present in zlib-1.3.1
Contributor
There was a problem hiding this comment.
In 1.3.1, zlib uses enable_testing. However, it does not build test if example build if off. Same with utf8, let's leave it here with a comment.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.